Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-06-27 17:48:38 +02:00
Code Issues Releases Wiki Activity

Steve pointed out to me that wx>TextCtrl Percent Change of -99.7 or lower causes crash in SoundTouch code, and anything below -99.0 is probably garbage, so I changed the bounds check to -99% (which matches the slider, too).

Browse Source
This commit is contained in:
v.audacity 2013-05-23 00:42:21 +00:00
parent 3f2c9d0c1d
commit 9d8bdb1cca
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/effects/ChangePitch.cpp
View File

@ -643,8 +643,8 @@ void ChangePitchDialog::OnText_ToFrequency(wxCommandEvent & WXUNUSED(event))
} }
} }
// m_PercentChange -100% makes no sense and Soundtouch is not reasonable above 3000%. // Soundtouch is not reasonable below -99% or above 3000%.
#define PERCENT_CHANGE_BEYOND_MIN -100.0 #define PERCENT_CHANGE_MIN -99.0
#define PERCENT_CHANGE_MAX 3000.0 #define PERCENT_CHANGE_MAX 3000.0
void ChangePitchDialog::OnText_PercentChange(wxCommandEvent & WXUNUSED(event)) void ChangePitchDialog::OnText_PercentChange(wxCommandEvent & WXUNUSED(event))
@ -658,7 +658,7 @@ void ChangePitchDialog::OnText_PercentChange(wxCommandEvent & WXUNUSED(event))
str.ToDouble(&newValue); str.ToDouble(&newValue);
// User might still be editing, so out of bounds is not an error, // User might still be editing, so out of bounds is not an error,
// but we do not want to update the values/controls. // but we do not want to update the values/controls.
if (str.IsEmpty() || (newValue <= PERCENT_CHANGE_BEYOND_MIN) || (newValue > PERCENT_CHANGE_MAX)) if (str.IsEmpty() || (newValue < PERCENT_CHANGE_MIN) || (newValue > PERCENT_CHANGE_MAX))
{ {
this->FindWindow(wxID_OK)->Disable(); this->FindWindow(wxID_OK)->Disable();
this->FindWindow(ID_EFFECT_PREVIEW)->Disable(); this->FindWindow(ID_EFFECT_PREVIEW)->Disable();
@ -764,7 +764,7 @@ void ChangePitchDialog::Update_Text_PercentChange()
str = wxT(""); str = wxT("");
m_pTextCtrl_PercentChange->SetValue(str); m_pTextCtrl_PercentChange->SetValue(str);
bool bIsGoodValue = (m_PercentChange > PERCENT_CHANGE_BEYOND_MIN) && (m_PercentChange <= PERCENT_CHANGE_MAX); bool bIsGoodValue = (m_PercentChange >= PERCENT_CHANGE_MIN) && (m_PercentChange <= PERCENT_CHANGE_MAX);
this->FindWindow(wxID_OK)->Enable(bIsGoodValue); this->FindWindow(wxID_OK)->Enable(bIsGoodValue);
this->FindWindow(ID_EFFECT_PREVIEW)->Enable(bIsGoodValue); this->FindWindow(ID_EFFECT_PREVIEW)->Enable(bIsGoodValue);
} }