ScrubbingToolBar consumes less idle time

src/toolbars/ScrubbingToolBar.cpp

@@ -142,6 +142,11 @@ void ScrubbingToolBar::UpdatePrefs()
 }
 
 void ScrubbingToolBar::RegenerateTooltips()
+{
+   DoRegenerateTooltips( true );
+}
+
+void ScrubbingToolBar::DoRegenerateTooltips( bool force )
 {
 #if wxUSE_TOOLTIPS
    auto fn = [&]
@@ -159,8 +164,10 @@ void ScrubbingToolBar::RegenerateTooltips()
       const auto seekButton = mButtons[STBSeekID];
 
       wxString label;
+      bool scrubs = scrubber.Scrubs();
+      if (force || mLastScrub != scrubs) {
          label = (
-               scrubber.Scrubs()
+                  scrubs
                   /* i18n-hint: These commands assist the user in finding a sound by ear. ...
                    "Scrubbing" is variable-speed playback, ...
                    "Seeking" is normal speed playback but with skips
@@ -169,9 +176,13 @@ void ScrubbingToolBar::RegenerateTooltips()
                   : _("Start Scrubbing")
                   );
          fn(*scrubButton, label, wxT("Scrub"));
+      }
+      mLastScrub = scrubs;
 
+      bool seeks = scrubber.Seeks();
+      if (force || mLastSeek != seeks) {
          label = (
-               scrubber.Seeks()
+                  seeks
                   /* i18n-hint: These commands assist the user in finding a sound by ear. ...
                    "Scrubbing" is variable-speed playback, ...
                    "Seeking" is normal speed playback but with skips
@@ -180,14 +191,20 @@ void ScrubbingToolBar::RegenerateTooltips()
                   : _("Start Seeking")
                   );
          fn(*seekButton, label, wxT("Seek"));
+      }
+      mLastSeek = seeks;
 
+      bool showingRuler = AdornedRulerPanel::Get( *project ).ShowingScrubRuler();
+      if (force || mLastRuler != showingRuler) {
          label = (
-               AdornedRulerPanel::Get( *project ).ShowingScrubRuler()
+                  showingRuler
                   ? _("Hide Scrub Ruler")
                   : _("Show Scrub Ruler")
                   );
          fn(*mButtons[STBRulerID], label, wxT("ToggleScrubRuler"));
       }
+      mLastRuler = showingRuler;
+   }
 #endif
 }
 
@@ -256,7 +273,7 @@ void ScrubbingToolBar::EnableDisableButtons()
       barButton->PushDown();
    else
       barButton->PopUp();
-   RegenerateTooltips();
+   DoRegenerateTooltips( false );
    scrubber.CheckMenuItems();
 }
 

src/toolbars/ScrubbingToolBar.h

@@ -78,6 +78,13 @@ public:
 
    DECLARE_CLASS(ScrubbingToolBar)
    DECLARE_EVENT_TABLE()
+
+private:
+   void DoRegenerateTooltips( bool force );
+
+   bool mLastScrub{ false };
+   bool mLastSeek{ false };
+   bool mLastRuler{ false };
 };
 
 #endif