mirror of
https://github.com/cookiengineer/audacity
synced 2025-10-22 14:32:58 +02:00
Replace virtual with override wherever possible; eliminate needless virtual...
... for functions in final classes. override is like const -- it's not necessary, but it helps the compiler to catch mistakes. There may be some overriding functions not explicitly declared virtual and I did not identify such cases, in which I might also add override.
This commit is contained in:
@@ -25,9 +25,9 @@ class WaveTrack;
|
||||
class CompareAudioCommandType final : public CommandType
|
||||
{
|
||||
public:
|
||||
virtual wxString BuildName();
|
||||
virtual void BuildSignature(CommandSignature &signature);
|
||||
virtual Command *Create(CommandOutputTarget *target);
|
||||
wxString BuildName() override;
|
||||
void BuildSignature(CommandSignature &signature) override;
|
||||
Command *Create(CommandOutputTarget *target) override;
|
||||
};
|
||||
|
||||
class CompareAudioCommand final : public CommandImplementation
|
||||
@@ -41,13 +41,13 @@ private:
|
||||
bool GetSelection(AudacityProject &proj);
|
||||
|
||||
protected:
|
||||
virtual double CompareSample(double value1, double value2);
|
||||
double CompareSample(double value1, double value2) /* not override */;
|
||||
|
||||
public:
|
||||
CompareAudioCommand(CommandType &type, CommandOutputTarget *target)
|
||||
: CommandImplementation(type, target)
|
||||
{ }
|
||||
virtual bool Apply(CommandExecutionContext context);
|
||||
bool Apply(CommandExecutionContext context) override;
|
||||
};
|
||||
|
||||
#endif /* End of include guard: __COMPAREAUDIOCOMMAND__ */
|
||||
|
Reference in New Issue
Block a user