Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-12-02 06:40:12 +01:00
Code Issues Releases Wiki Activity

Module manager (#549)

Browse Source 
* Eliminate ModuleManagerInterface...

... It was there only to provide RegisterModule(), but that was not used
anywhere.  So simplify.

* Remove nested #include of ModuleInterface.h
This commit is contained in:
Paul Licameli
2020-05-29 11:48:52 -04:00
committed by GitHub
parent 5bede69d11
commit 9360359e9d
22 changed files with 35 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
include/audacity/ModuleInterface.h
View File

@@ -135,20 +135,6 @@ public:
virtual void DeleteInstance(ComponentInterface *instance) = 0;
};
// ============================================================================
//
// ModuleManagerInterface class
//
// ============================================================================
class ModuleManagerInterface /* not final */
{
public:
// Modules call this to register their interface
virtual void RegisterModule(ModuleInterface *module) = 0;
};
// ----------------------------------------------------------------------------
// The default entry point name and the name that will be searched for during
// load if the module has been built as a external library.
@@ -158,8 +144,7 @@ public:
// ----------------------------------------------------------------------------
// The module entry point prototype
// ----------------------------------------------------------------------------
typedef ModuleInterface *(*ModuleMain)(ModuleManagerInterface *moduleManager,
const wxString *path);
typedef ModuleInterface *(*ModuleMain)(const wxString *path);
// ----------------------------------------------------------------------------
// If BUILDING_AUDACITY is defined during the current build, it is assumed
@@ -172,7 +157,7 @@ typedef ModuleInterface *(*ModuleMain)(ModuleManagerInterface *moduleManager,
// be declared static so as not to interfere with other modules during link.
// ----------------------------------------------------------------------------
#define DECLARE_MODULE_ENTRY(name) \
static ModuleInterface * name(ModuleManagerInterface *moduleManager, const wxString *path)
static ModuleInterface * name(const wxString *path)
// ----------------------------------------------------------------------------
// This will create a class and instnace that will register the module entry
@@ -214,8 +199,7 @@ void name::Register() \
// ----------------------------------------------------------------------------
#define DECLARE_MODULE_ENTRY(name) \
extern "C" __declspec(dllexport) \
ModuleInterface * name(ModuleManagerInterface *moduleManager, \
const wxString *path)
ModuleInterface * name(const wxString *path)
// ----------------------------------------------------------------------------
// Define these as empty will effectively remove the embedded registration

1
include/audacity/PluginInterface.h
View File

@@ -46,7 +46,6 @@
#include "audacity/EffectInterface.h"
#include "audacity/ComponentInterface.h"
#include "audacity/ImporterInterface.h"
#include "audacity/ModuleInterface.h"
class ModuleInterface;