Fix assertion violations about double capture; while still making sure...

... that if you drag-scrub and ESC, you don't get a leftover white guide line.

src/tracks/ui/Scrubbing.cpp

@@ -411,11 +411,6 @@ void Scrubber::StopScrubbing()
    }
 
    mProject->GetRulerPanel()->HideQuickPlayIndicator();
-
-   // Need this in case ruler gets the mouse-up event after escaping scrubbing:
-   // prevent reappearance of the
-   // quick play guideline
-   mProject->GetRulerPanel()->IgnoreMouseUp();
 }
 
 bool Scrubber::IsScrubbing() const

src/widgets/Ruler.cpp

@@ -2328,17 +2328,6 @@ bool AdornedRulerPanel::IsWithinMarker(int mousePosX, double markerTime)
 
 void AdornedRulerPanel::OnMouseEvents(wxMouseEvent &evt)
 {
-   if (mIgnoreMouseUp) {
-      if (evt.Dragging())
-         return;
-      else if (evt.ButtonUp()) {
-         mIgnoreMouseUp = false;
-         return;
-      }
-      else
-         mIgnoreMouseUp = false;
-   }
-
    // PRL:  why do I need these two lines on Windows but not on Mac?
    if (evt.ButtonDown(wxMOUSE_BTN_ANY))
       SetFocus();
@@ -2516,13 +2505,16 @@ void AdornedRulerPanel::OnMouseEvents(wxMouseEvent &evt)
          mDoubleClick = false;
          HandleQPClick(evt, mousePosX);
          HandleQPDrag(evt, mousePosX);
+         ShowQuickPlayIndicator();
       }
-      else if (evt.LeftIsDown())
+      else if (evt.LeftIsDown() && HasCapture()) {
          HandleQPDrag(evt, mousePosX);
-      else if (evt.LeftUp())
+         ShowQuickPlayIndicator();
+      }
+      else if (evt.LeftUp() && HasCapture()) {
          HandleQPRelease(evt);
-
-      ShowQuickPlayIndicator();
+         ShowQuickPlayIndicator();
+      }
    }
 }
 

src/widgets/Ruler.h

@@ -354,7 +354,6 @@ public:
    void ShowQuickPlayIndicator();
    void HideQuickPlayIndicator();
    void UpdateQuickPlayPos(wxCoord &mousPosX);
-   void IgnoreMouseUp() { mIgnoreMouseUp = true; }
 
 private:
    void OnCapture(wxCommandEvent & evt);
@@ -536,7 +535,6 @@ private:
    mutable wxFont mButtonFont;
 
    bool mDoubleClick {};
-   bool mIgnoreMouseUp {};
 
    DECLARE_EVENT_TABLE()