Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2026-03-04 13:40:58 +01:00
Code Issues Releases Wiki Activity

Sweep unnecessary wxString copies: commands

Browse Source
This commit is contained in:
Paul Licameli
2016-02-22 21:17:41 -05:00
parent 99f161c36c
commit 923a6ce4af
11 changed files with 60 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/commands/CommandBuilder.cpp
View File

@@ -87,7 +87,7 @@ void CommandBuilder::Success(Command *cmd)
}
void CommandBuilder::BuildCommand(const wxString &cmdName,
wxString cmdParams)
const wxString &cmdParamsArg)
{
// Stage 1: create a Command object of the right type
@@ -106,7 +106,7 @@ void CommandBuilder::BuildCommand(const wxString &cmdName,
wxASSERT(type != NULL);
mCommand = type->Create(output);
mCommand->SetParameter(wxT("CommandName"), cmdName);
mCommand->SetParameter(wxT("ParamString"), cmdParams);
mCommand->SetParameter(wxT("ParamString"), cmdParamsArg);
Success(new ApplyAndSendResponse(mCommand));
return;
}
@@ -117,7 +117,7 @@ void CommandBuilder::BuildCommand(const wxString &cmdName,
// Stage 2: set the parameters
ShuttleCli shuttle;
shuttle.mParams = cmdParams;
shuttle.mParams = cmdParamsArg;
shuttle.mbStoreInClient = true;
ParamValueMap::const_iterator iter;
@@ -138,6 +138,8 @@ void CommandBuilder::BuildCommand(const wxString &cmdName,
// Check for unrecognised parameters
wxString cmdParams(cmdParamsArg);
while (cmdParams != wxEmptyString)
{
cmdParams.Trim(true);
@@ -166,8 +168,10 @@ void CommandBuilder::BuildCommand(const wxString &cmdName,
Success(new ApplyAndSendResponse(mCommand));
}
void CommandBuilder::BuildCommand(wxString cmdString)
void CommandBuilder::BuildCommand(const wxString &cmdStringArg)
{
wxString cmdString(cmdStringArg);
// Find the command name terminator... If there is more than one word and
// no terminator, the command is badly formed
cmdString.Trim(true); cmdString.Trim(false);