1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-10-22 06:22:58 +02:00

Sweep unnecessary wxString copies: commands

This commit is contained in:
Paul Licameli
2016-02-22 21:17:41 -05:00
parent 99f161c36c
commit 923a6ce4af
11 changed files with 60 additions and 56 deletions

View File

@@ -61,8 +61,8 @@ class Command
{
public:
virtual void Progress(double completed) = 0;
virtual void Status(wxString message) = 0;
virtual void Error(wxString message) = 0;
virtual void Status(const wxString &message) = 0;
virtual void Error(const wxString &message) = 0;
virtual ~Command() { }
virtual wxString GetName() = 0;
virtual CommandSignature &GetSignature() = 0;
@@ -77,8 +77,8 @@ protected:
Command *mCommand;
public:
virtual void Progress(double completed);
virtual void Status(wxString message);
virtual void Error(wxString message);
virtual void Status(const wxString &message) override;
virtual void Error(const wxString &message) override;
DecoratedCommand(Command *cmd)
: mCommand(cmd)
@@ -130,8 +130,8 @@ protected:
public:
// Convenience methods for passing messages to the output target
void Progress(double completed);
void Status(wxString status);
void Error(wxString message);
void Status(const wxString &status) override;
void Error(const wxString &message) override;
/// Constructor should not be called directly; only by a factory which
/// ensures name and params are set appropriately for the command.