Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-12-02 06:40:12 +01:00
Code Issues Releases Wiki Activity

Remove the nullary override of Effect::Preview

Browse Source
This commit is contained in:
Paul Licameli
2019-07-21 16:26:03 -04:00
parent b7ddd7dc53
commit 91515520bc
5 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/audacity/EffectInterface.h
View File

@@ -123,8 +123,6 @@ public:
virtual NumericFormatSymbol GetDurationFormat() = 0; virtual NumericFormatSymbol GetDurationFormat() = 0;
virtual void SetDuration(double seconds) = 0; virtual void SetDuration(double seconds) = 0;
virtual void Preview() = 0;
// Preset handling // Preset handling
virtual RegistryPath GetUserPresetsGroup(const RegistryPath & name) = 0; virtual RegistryPath GetUserPresetsGroup(const RegistryPath & name) = 0;
virtual RegistryPath GetCurrentSettingsGroup() = 0; virtual RegistryPath GetCurrentSettingsGroup() = 0;

5
src/effects/Effect.cpp
View File

@@ -728,11 +728,6 @@ void Effect::SetDuration(double seconds)
return; return;
} }
void Effect::Preview()
{
Preview(false);
}
RegistryPath Effect::GetUserPresetsGroup(const RegistryPath & name) RegistryPath Effect::GetUserPresetsGroup(const RegistryPath & name)
{ {
RegistryPath group = wxT("UserPresets"); RegistryPath group = wxT("UserPresets");

2
src/effects/Effect.h
View File

@@ -179,8 +179,6 @@ class AUDACITY_DLL_API Effect /* not final */ : public wxEvtHandler,
virtual NumericFormatSymbol GetSelectionFormat() /* not override? */; // time format in Selection toolbar virtual NumericFormatSymbol GetSelectionFormat() /* not override? */; // time format in Selection toolbar
void SetDuration(double duration) override; void SetDuration(double duration) override;
void Preview() override;
RegistryPath GetUserPresetsGroup(const RegistryPath & name) override; RegistryPath GetUserPresetsGroup(const RegistryPath & name) override;
RegistryPath GetCurrentSettingsGroup() override; RegistryPath GetCurrentSettingsGroup() override;
RegistryPath GetFactoryDefaultsGroup() override; RegistryPath GetFactoryDefaultsGroup() override;

2
src/effects/NoiseReduction.cpp
View File

@@ -1687,7 +1687,7 @@ void EffectNoiseReduction::Dialog::OnPreview(wxCommandEvent & WXUNUSED(event))
*m_pSettings = mTempSettings; *m_pSettings = mTempSettings;
m_pSettings->mDoProfile = false; m_pSettings->mDoProfile = false;
m_pEffect->Preview(); m_pEffect->Preview( false );
} }
void EffectNoiseReduction::Dialog::OnReduceNoise( wxCommandEvent & WXUNUSED(event)) void EffectNoiseReduction::Dialog::OnReduceNoise( wxCommandEvent & WXUNUSED(event))

2
src/effects/NoiseRemoval.cpp
View File

@@ -689,7 +689,7 @@ void NoiseRemovalDialog::OnPreview(wxCommandEvent & WXUNUSED(event))
m_pEffect->mDoProfile = oldDoProfile; m_pEffect->mDoProfile = oldDoProfile;
} ); } );
m_pEffect->Preview(); m_pEffect->Preview( false );
} }
void NoiseRemovalDialog::OnRemoveNoise( wxCommandEvent & WXUNUSED(event)) void NoiseRemovalDialog::OnRemoveNoise( wxCommandEvent & WXUNUSED(event))