Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-09-17 16:50:26 +02:00
Code Issues Releases Wiki Activity

Fix unbalanced event handler push/pop

Browse Source 
Fix was provided by Hans Petter Selasky with the following comment:

   This is a regression issue after:

   Move the scrub mouse event handler into ScrubUI...

   Where:
      if (mWindow)
           mWindow->PushEventHandler(&mForwarder);

   was removed from the Scrubber() constructor function and
   not from the ~Scrubber().
This commit is contained in:
Leland Lucius 2020-02-21 10:57:30 -06:00
parent 26827bc5e5
commit 8ac5699fcd
2 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/tracks/ui/ScrubUI.cpp
View File

@ -271,7 +271,6 @@ static const AudacityProject::AttachedObjects::RegisteredFactory sForwarderKey{
[]( AudacityProject &parent ){ []( AudacityProject &parent ){
auto result = std::make_shared< ScrubForwarder >( parent ); auto result = std::make_shared< ScrubForwarder >( parent );
auto &window = ProjectWindow::Get( parent ); auto &window = ProjectWindow::Get( parent );
window.PushEventHandler( result.get() );
return result; return result;
} }
}; };

3
src/tracks/ui/Scrubbing.cpp
View File

@ -241,9 +241,6 @@ Scrubber::~Scrubber()
if (mpThread) if (mpThread)
mpThread->Delete(); mpThread->Delete();
#endif #endif
if ( mWindow )
mWindow->PopEventHandler();
} }
static const auto HasWaveDataPred = static const auto HasWaveDataPred =