1
0
mirror of https://github.com/cookiengineer/audacity synced 2026-02-18 00:37:59 +01:00

Fewer C-style pointer casts of tracks; comments justify static_cast

This commit is contained in:
Paul Licameli
2016-09-15 09:54:38 -04:00
parent 837173e9ad
commit 88611a4530
18 changed files with 223 additions and 164 deletions

View File

@@ -5233,38 +5233,36 @@ void AudacityProject::DoTrackSolo(Track *t, bool exclusive)
mTrackPanel->Refresh(false);
}
void AudacityProject::SetTrackGain(Track * track, LWSlider * slider)
void AudacityProject::SetTrackGain(WaveTrack * wt, LWSlider * slider)
{
wxASSERT(track);
if (track->GetKind() != Track::Wave)
return;
wxASSERT(wt);
float newValue = slider->Get();
WaveTrack *const link = static_cast<WaveTrack*>(mTracks->GetLink(track));
static_cast<WaveTrack*>(track)->SetGain(newValue);
// Assume linked track is wave or null
const auto link = static_cast<WaveTrack*>(mTracks->GetLink(wt));
wt->SetGain(newValue);
if (link)
link->SetGain(newValue);
PushState(_("Adjusted gain"), _("Gain"), UndoPush::CONSOLIDATE);
GetTrackPanel()->RefreshTrack(track);
GetTrackPanel()->RefreshTrack(wt);
}
void AudacityProject::SetTrackPan(Track * track, LWSlider * slider)
void AudacityProject::SetTrackPan(WaveTrack * wt, LWSlider * slider)
{
wxASSERT(track);
if (track->GetKind() != Track::Wave)
return;
wxASSERT(wt);
float newValue = slider->Get();
WaveTrack *const link = static_cast<WaveTrack*>(mTracks->GetLink(track));
static_cast<WaveTrack*>(track)->SetPan(newValue);
// Assume linked track is wave or null
const auto link = static_cast<WaveTrack*>(mTracks->GetLink(wt));
wt->SetPan(newValue);
if (link)
link->SetPan(newValue);
PushState(_("Adjusted Pan"), _("Pan"), UndoPush::CONSOLIDATE);
GetTrackPanel()->RefreshTrack(track);
GetTrackPanel()->RefreshTrack(wt);
}
/// Removes the specified track. Called from HandleClosing.