fixing strict-aliasing rule violations by passing enum types as int references

src/WaveTrack.cpp

@@ -263,7 +263,7 @@ WaveTrack::WaveTrackDisplay WaveTrack::FindDefaultViewMode()
    // Prefer the NEW preference key if it is present
 
    WaveTrack::WaveTrackDisplay viewMode;
-   gPrefs->Read(wxT("/GUI/DefaultViewModeNew"), (int*)&viewMode, -1);
+   gPrefs->Read(wxT("/GUI/DefaultViewModeNew"), &viewMode, -1);
 
    // Default to the old key only if not, default the value if it's not there either
    wxASSERT(WaveTrack::MinDisplay >= 0);

src/WaveTrack.h

@@ -527,7 +527,9 @@ private:
    // and will be taken out of the WaveTrack class:
    //
 
-   enum WaveTrackDisplay {
+
+   typedef int WaveTrackDisplay;
+   enum WaveTrackDisplayValues : int {
 
       // DO NOT REORDER OLD VALUES!  Replace obsoletes with placeholders.
 

src/commands/SetTrackInfoCommand.cpp

@@ -167,7 +167,7 @@ bool SetTrackCommand::Apply(const CommandContext & context)
    bool bIsSecondChannel = false;
    while (t )
    {
-      bool bThisTrack = 
+      bool bThisTrack =
          (bHasTrackIndex && (i==mTrackIndex)) ||
          (bHasChannelIndex && (j==mChannelIndex ) ) ||
          (!bHasTrackIndex && !bHasChannelIndex) ;
@@ -191,9 +191,9 @@ bool SetTrackCommand::Apply(const CommandContext & context)
 
          if( wt && bHasDisplayType  )
             wt->SetDisplay(
-               (mDisplayType == kWaveform) ? 
+               (mDisplayType == kWaveform) ?
-                  WaveTrack::WaveTrackDisplay::Waveform
+                  WaveTrack::WaveTrackDisplayValues::Waveform
-                  : WaveTrack::WaveTrackDisplay::Spectrum
+                  : WaveTrack::WaveTrackDisplayValues::Spectrum
                );
          if( wt && bHasScaleType )
             wt->GetIndependentWaveformSettings().scaleType = 

src/prefs/SpectrogramSettings.h

@@ -53,7 +53,8 @@ public:
    // Do not assume that this enumeration will remain the
    // same as NumberScaleType in future.  That enum may become
    // more general purpose.
-   enum ScaleType {
+   typedef int ScaleType;
+   enum ScaleTypeValues : int {
       stLinear,
       stLogarithmic,
       stMel,
@@ -131,7 +132,8 @@ public:
    bool spectralSelection; // But should this vary per track? -- PRL
 #endif
 
-   enum Algorithm {
+   typedef int Algorithm;
+   enum AlgorithmValues : int {
       algSTFT = 0,
       algReassignment,
       algPitchEAC,

src/prefs/SpectrumPrefs.cpp

@@ -176,7 +176,7 @@ void SpectrumPrefs::PopulateOrExchange(ShuttleGui & S)
       S.StartTwoColumn();
       {
          S.Id(ID_SCALE).TieChoice(_("S&cale") + wxString(wxT(":")),
-            *(int*)&mTempSettings.scaleType,
+            mTempSettings.scaleType,
             &mScaleChoices);
 
          mMinFreq =
@@ -226,7 +226,7 @@ void SpectrumPrefs::PopulateOrExchange(ShuttleGui & S)
       {
          mAlgorithmChoice =
             S.Id(ID_ALGORITHM).TieChoice(_("A&lgorithm") + wxString(wxT(":")),
-            *(int*)&mTempSettings.algorithm,
+            mTempSettings.algorithm,
             &mAlgorithmChoices);
 
          S.Id(ID_WINDOW_SIZE).TieChoice(_("Window &size:"),

src/prefs/WaveformPrefs.cpp

@@ -92,12 +92,12 @@ void WaveformPrefs::PopulateOrExchange(ShuttleGui & S)
          {
             mScaleChoice =
                S.Id(ID_SCALE).TieChoice(_("S&cale") + wxString(wxT(":")),
-                  *(int*)&mTempSettings.scaleType,
+                  mTempSettings.scaleType,
                   &mScaleChoices);
 
             mRangeChoice =
                S.Id(ID_RANGE).TieChoice(_("Waveform dB &range") + wxString(wxT(":")),
-               *(int*)&mTempSettings.dBRange,
+               mTempSettings.dBRange,
                &mRangeChoices);
             S.SetSizeHints(mRangeChoices);
          }

src/prefs/WaveformSettings.h

@@ -50,7 +50,8 @@ public:
    void NextLowerDBRange();
    void NextHigherDBRange();
 
-   enum ScaleType {
+   typedef int ScaleType;
+   enum ScaleTypeValues : int {
       stLinear,
       stLogarithmic,