1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-10-26 23:33:49 +01:00

Use global ChoiceSettings variables, not coincidental string literals

This commit is contained in:
Paul Licameli
2019-04-02 18:40:42 -04:00
parent 9b41741074
commit 87a9e7ccbb
14 changed files with 41 additions and 30 deletions

View File

@@ -18,6 +18,7 @@
#include "../effects/Contrast.h"
#include "../effects/EffectManager.h"
#include "../effects/RealtimeEffectManager.h"
#include "../prefs/EffectsPrefs.h"
// private helper classes and functions
namespace {
@@ -195,7 +196,7 @@ void AddEffectMenuItems(
{
size_t pluginCnt = plugs.size();
wxString groupBy = gPrefs->Read(wxT("/Effects/GroupBy"), wxT("sortby:name"));
auto groupBy = EffectsGroupBy.Read();
bool grouped = false;
if (groupBy.StartsWith(wxT("groupby")))
@@ -382,7 +383,7 @@ MenuTable::BaseItemPtrs PopulateEffectsMenu(
plug = pm.GetNextPluginForEffectType(type);
}
wxString groupby = gPrefs->Read(wxT("/Effects/GroupBy"), wxT("sortby:name"));
wxString groupby = EffectsGroupBy.Read();
using Comparator = bool(*)(const PluginDescriptor*, const PluginDescriptor*);
Comparator comp1, comp2;