Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2026-01-13 08:05:52 +01:00
Code Issues Releases Wiki Activity

bug 309: Get rid of incremental fix now that correct fix is in PitchIndex().

Browse Source
This commit is contained in:
v.audacity
2013-06-15 00:28:04 +00:00
parent 0e9fa580f5
commit 820b889475
2 changed files with 0 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/effects/ChangePitch.cpp
View File

@@ -462,14 +462,6 @@ bool ChangePitchDialog::TransferDataFromWindow()
// calculations // calculations
//vvvvv Probaly unnecessary with fix to FreqToMIDInoteNumber(), but leave it in until we decide how to handle very low freq values.
void ChangePitchDialog::Calc_FromPitchIndex()
{
m_FromPitchIndex = (int)(m_ToPitchIndex - m_SemitonesChange) % 12;
if (m_FromPitchIndex < 0)
m_FromPitchIndex += 12;
}
void ChangePitchDialog::Calc_ToPitchIndex() void ChangePitchDialog::Calc_ToPitchIndex()
{ {
int nSemitonesChange = int nSemitonesChange =
@@ -601,14 +593,6 @@ void ChangePitchDialog::OnText_FromFrequency(wxCommandEvent & WXUNUSED(event))
this->Calc_ToFrequency(); this->Calc_ToFrequency();
this->Calc_ToPitchIndex(); this->Calc_ToPitchIndex();
//vvvvv Probaly unnecessary with fix to FreqToMIDInoteNumber(), but leave it in until we decide how to handle very low freq values.
// This is Steve's incremental fix for cross-updating issues related to bug 309.
// It's weird that in prior code (3 lines above this), we set m_FromPitchIndex,
// then call 2 Calc methods for the other members, and then this call to
// recalculate m_FromPitchIndex. Something's wrong there, but I want to figure
// out the overall best scheme, and this is an incremental fix.
// this->Calc_FromPitchIndex();
m_bLoopDetect = true; m_bLoopDetect = true;
this->Update_Choice_FromPitch(); this->Update_Choice_FromPitch();
this->Update_Choice_ToPitch(); this->Update_Choice_ToPitch();

1
src/effects/ChangePitch.h
View File

@@ -95,7 +95,6 @@ class ChangePitchDialog:public EffectDialog {
private: private:
// calculations // calculations
void Calc_FromPitchIndex(); // Update m_FromPitchIndex from new m_ToPitchIndex.
void Calc_ToPitchIndex(); // Update m_ToPitchIndex from new m_SemitonesChange. void Calc_ToPitchIndex(); // Update m_ToPitchIndex from new m_SemitonesChange.
void Calc_SemitonesChange_fromPitches(); // Update m_SemitonesChange from new m_*PitchIndex-es. void Calc_SemitonesChange_fromPitches(); // Update m_SemitonesChange from new m_*PitchIndex-es.
void Calc_SemitonesChange_fromPercentChange(); // Update m_SemitonesChange from new m_PercentChange. void Calc_SemitonesChange_fromPercentChange(); // Update m_SemitonesChange from new m_PercentChange.