Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-11-23 17:30:17 +01:00
Code Issues Releases Wiki Activity

wxWidgets docs recommend: don't SetSizeHints on non-top-level windows

Browse Source
This commit is contained in:
Paul Licameli
2018-01-30 01:06:23 -05:00
parent c67a47e3e6
commit 7ccd35d219
9 changed files with 29 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/widgets/AButton.cpp
View File

@@ -271,8 +271,8 @@ void AButton::Init(wxWindow * parent,
mFocusRect = GetClientRect().Deflate( 3, 3 );
mForceFocusRect = false;
SetSizeHints(mImages[0].mArr[0].GetMinSize(),
mImages[0].mArr[0].GetMaxSize());
SetMinSize(mImages[0].mArr[0].GetMinSize());
SetMaxSize(mImages[0].mArr[0].GetMaxSize());
#if wxUSE_ACCESSIBILITY
SetName( wxT("") );

19
src/widgets/ExpandingToolBar.cpp
View File

@@ -380,7 +380,8 @@ void ExpandingToolBar::Fit()
mCurrentDrawerSize = wxSize(mExtraSize.x, 0);
mCurrentTotalSize = baseWindowSize;
SetSizeHints(mCurrentTotalSize, mCurrentTotalSize);
SetMinSize(mCurrentTotalSize);
SetMaxSize(mCurrentTotalSize);
SetSize(mCurrentTotalSize);
}
@@ -434,7 +435,8 @@ void ExpandingToolBar::MoveDrawer(wxSize prevSize)
if (mFrameParent) {
// If we're in a tool window
SetSizeHints(mCurrentTotalSize, mCurrentTotalSize);
SetMinSize(mCurrentTotalSize);
SetMaxSize(mCurrentTotalSize);
SetSize(mCurrentTotalSize);
GetParent()->Fit();
@@ -443,7 +445,8 @@ void ExpandingToolBar::MoveDrawer(wxSize prevSize)
if (mDialogParent) {
// If we're in a dialog
SetSizeHints(mCurrentTotalSize, mCurrentTotalSize);
SetMinSize(mCurrentTotalSize);
SetMaxSize(mCurrentTotalSize);
SetSize(mCurrentTotalSize);
GetParent()->Fit();
@@ -457,7 +460,8 @@ void ExpandingToolBar::MoveDrawer(wxSize prevSize)
mExtraPanel->Show();
}
mExtraPanel->SetSizeHints(mCurrentDrawerSize, mCurrentDrawerSize);
mExtraPanel->SetMinSize(mCurrentDrawerSize);
mExtraPanel->SetMaxSize(mCurrentDrawerSize);
mExtraPanel->SetSize(mCurrentDrawerSize);
if (mCurrentDrawerSize.y == 0)
@@ -680,8 +684,8 @@ ToolBarGrabber::ToolBarGrabber(wxWindow *parent,
images[1],
magicColor);
SetSizeHints(mImageRoll[0].GetMinSize(),
mImageRoll[1].GetMaxSize());
SetMinSize(mImageRoll[0].GetMinSize());
SetMaxSize(mImageRoll[1].GetMaxSize());
#endif
mState = 0;
}
@@ -1094,7 +1098,8 @@ void ToolBarArea::Fit(bool horizontal, bool vertical)
maxSize != mMaxSize) {
mMinSize = minSize;
mMaxSize = maxSize;
SetSizeHints(mMinSize, mMaxSize);
SetMinSize(mMinSize);
SetMaxSize(mMaxSize);
}
if (actualSize != mActualSize) {
mActualSize = actualSize;

4
src/widgets/ImageRoll.cpp
View File

@@ -435,8 +435,8 @@ ImageRollPanel::ImageRollPanel(wxWindow *parent,
//mImageRoll(imgRoll),
mLogicalFunction(wxCOPY)
{
// SetSizeHints(mImageRoll.GetMinSize(),
// mImageRoll.GetMaxSize());
// SetMinSize(mImageRoll.GetMinSize());
// SetMaxSize(mImageRoll.GetMaxSize());
}
void ImageRollPanel::SetLogicalFunction(int /*wxRasterOperationMode*/ func)