Fix move constructors and assignments of AudacityException classes

src/AudacityException.cpp

@@ -31,6 +31,7 @@ MessageBoxException &MessageBoxException::operator = ( MessageBoxException &&tha
 {
    caption = that.caption;
    if ( this != &that ) {
+      AudacityException::operator=( std::move(that) );
       if (!moved)
          wxAtomicDec( sOutstandingMessages );
 

src/FileException.h

@@ -27,8 +27,13 @@ public:
 
    FileException(FileException&& that)
       : MessageBoxException(std::move(that))
+      , cause{ that.cause }
+      , fileName{ that.fileName }
+      , renameTarget{ that.renameTarget }
    {}
 
+   FileException& operator= (FileException&&) PROHIBITED;
+
    ~FileException() override;
 
 protected:

src/InconsistencyException.h

@@ -27,11 +27,18 @@ public:
 
    InconsistencyException(InconsistencyException&& that)
       : MessageBoxException(std::move(that))
+      , func{ that.func }
+      , file{ that.file }
+      , line{ that.line }
    {}
    InconsistencyException &operator = (InconsistencyException &&that)
    {
-      if (this != &that)
+      if (this != &that) {
-         operator= (std::move(that));
+         MessageBoxException::operator= (std::move(that));
+         func = that.func;
+         file = that.file;
+         line = that.line;
+      }
       return *this;
    }
 

src/UserException.h

@@ -25,6 +25,8 @@ public:
       : AudacityException{ std::move( that ) }
    {}
 
+   UserException& operator= (UserException&&) PROHIBITED;
+
    ~UserException() override;
 
    void DelayedHandlerAction() override;

src/blockfile/NotYetAvailableException.cpp

@@ -23,6 +23,6 @@ wxString NotYetAvailableException::ErrorMessage() const
 {
    return wxString::Format(
       _("This operation cannot be done until importation of %s completes."),
-      mFileName.GetFullName()
+      fileName.GetFullName()
    );
 }

src/blockfile/NotYetAvailableException.h

@@ -21,14 +21,12 @@ public:
       : FileException{ Cause::Read, fileName } {}
    NotYetAvailableException(NotYetAvailableException &&that)
       : FileException( std::move( that ) ) {}
+   NotYetAvailableException& operator= (NotYetAvailableException&&) PROHIBITED;
    ~NotYetAvailableException();
 
 protected:
    std::unique_ptr< AudacityException > Move() override;
    wxString ErrorMessage() const override;
-
-private:
-   wxFileName mFileName;
 };
 
 #endif