Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-11-14 17:14:07 +01:00
Code Issues Releases Wiki Activity

Harmlessly qualify classes as final (or explicitly comment not)...

Browse Source 
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls.  Mostly useful as documentation of design intent.

Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
This commit is contained in:
Paul Licameli
2016-02-24 01:06:39 -05:00
parent e2f7e5f6f6
commit 7824e94030
261 changed files with 480 additions and 472 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/xml/XMLFileReader.h
View File

@@ -15,7 +15,7 @@
#include "XMLTagHandler.h"
class AUDACITY_DLL_API XMLFileReader {
class AUDACITY_DLL_API XMLFileReader final {
public:
XMLFileReader();
virtual ~XMLFileReader();

2
src/xml/XMLTagHandler.h
View File

@@ -66,7 +66,7 @@ public:
};
class AUDACITY_DLL_API XMLTagHandler {
class AUDACITY_DLL_API XMLTagHandler /* not final */ {
public:
XMLTagHandler(){};
virtual ~XMLTagHandler(){};

6
src/xml/XMLWriter.h
View File

@@ -17,7 +17,7 @@
///
/// XMLWriter
///
class AUDACITY_DLL_API XMLWriter {
class AUDACITY_DLL_API XMLWriter /* not final */ {
public:
@@ -60,7 +60,7 @@ class AUDACITY_DLL_API XMLWriter {
///
/// XMLFileWriter
///
class AUDACITY_DLL_API XMLFileWriter:public wxFFile, public XMLWriter {
class AUDACITY_DLL_API XMLFileWriter final : public wxFFile, public XMLWriter {
public:
@@ -100,7 +100,7 @@ protected:
///
/// XMLStringWriter
///
class XMLStringWriter:public wxString, public XMLWriter {
class XMLStringWriter final : public wxString, public XMLWriter {
public: