Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-10-26 07:13:49 +01:00
Code Issues Releases Wiki Activity

Harmlessly qualify classes as final (or explicitly comment not)...

Browse Source 
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls.  Mostly useful as documentation of design intent.

Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
This commit is contained in:
Paul Licameli
2016-02-24 01:06:39 -05:00
parent e2f7e5f6f6
commit 7824e94030
261 changed files with 480 additions and 472 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/prefs/BatchPrefs.h
View File

@@ -20,7 +20,7 @@
class ShuttleGui;
class BatchPrefs : public PrefsPanel
class BatchPrefs final : public PrefsPanel
{
public:
BatchPrefs(wxWindow * parent);
@@ -34,7 +34,7 @@ private:
DECLARE_EVENT_TABLE();
};
class BatchPrefsFactory : public PrefsPanelFactory
class BatchPrefsFactory final : public PrefsPanelFactory
{
public:
virtual PrefsPanel *Create(wxWindow *parent);

4
src/prefs/DevicePrefs.h
View File

@@ -23,7 +23,7 @@
class ShuttleGui;
class DevicePrefs :public PrefsPanel
class DevicePrefs final : public PrefsPanel
{
public:
DevicePrefs(wxWindow * parent);
@@ -54,7 +54,7 @@ class DevicePrefs :public PrefsPanel
DECLARE_EVENT_TABLE();
};
class DevicePrefsFactory : public PrefsPanelFactory
class DevicePrefsFactory final : public PrefsPanelFactory
{
public:
virtual PrefsPanel *Create(wxWindow *parent);

4
src/prefs/DirectoriesPrefs.h
View File

@@ -18,7 +18,7 @@
class ShuttleGui;
class DirectoriesPrefs :public PrefsPanel
class DirectoriesPrefs final : public PrefsPanel
{
public:
DirectoriesPrefs(wxWindow * parent);
@@ -38,7 +38,7 @@ class DirectoriesPrefs :public PrefsPanel
DECLARE_EVENT_TABLE();
};
class DirectoriesPrefsFactory : public PrefsPanelFactory
class DirectoriesPrefsFactory final : public PrefsPanelFactory
{
public:
virtual PrefsPanel *Create(wxWindow *parent);

4
src/prefs/EffectsPrefs.h
View File

@@ -22,7 +22,7 @@
class ShuttleGui;
class EffectsPrefs :public PrefsPanel
class EffectsPrefs final : public PrefsPanel
{
public:
EffectsPrefs(wxWindow * parent);
@@ -34,7 +34,7 @@ class EffectsPrefs :public PrefsPanel
void PopulateOrExchange(ShuttleGui & S);
};
class EffectsPrefsFactory : public PrefsPanelFactory
class EffectsPrefsFactory final : public PrefsPanelFactory
{
public:
virtual PrefsPanel *Create(wxWindow *parent);

6
src/prefs/ExtImportPrefs.h
View File

@@ -26,7 +26,7 @@ class wxListEvent;
class ExtImportPrefs;
class ShuttleGui;
class ExtImportPrefsDropTarget: public wxDropTarget
class ExtImportPrefsDropTarget final : public wxDropTarget
{
public:
ExtImportPrefsDropTarget (wxDataObject *dataObject = 0);
@@ -42,7 +42,7 @@ private:
ExtImportPrefs *mPrefs;
};
class ExtImportPrefs:public PrefsPanel
class ExtImportPrefs final : public PrefsPanel
{
public:
ExtImportPrefs(wxWindow * parent);
@@ -108,7 +108,7 @@ class ExtImportPrefs:public PrefsPanel
};
class ExtImportPrefsFactory : public PrefsPanelFactory
class ExtImportPrefsFactory final : public PrefsPanelFactory
{
public:
virtual PrefsPanel *Create(wxWindow *parent);

4
src/prefs/GUIPrefs.h
View File

@@ -22,7 +22,7 @@
class ShuttleGui;
class GUIPrefs :public PrefsPanel
class GUIPrefs final : public PrefsPanel
{
public:
GUIPrefs(wxWindow * parent);
@@ -45,7 +45,7 @@ class GUIPrefs :public PrefsPanel
wxArrayString mRangeChoices;
};
class GUIPrefsFactory : public PrefsPanelFactory
class GUIPrefsFactory final : public PrefsPanelFactory
{
public:
virtual PrefsPanel *Create(wxWindow *parent);

4
src/prefs/ImportExportPrefs.h
View File

@@ -21,7 +21,7 @@
class ShuttleGui;
class ImportExportPrefs :public PrefsPanel
class ImportExportPrefs final : public PrefsPanel
{
public:
ImportExportPrefs(wxWindow * parent);
@@ -33,7 +33,7 @@ class ImportExportPrefs :public PrefsPanel
void PopulateOrExchange(ShuttleGui & S);
};
class ImportExportPrefsFactory : public PrefsPanelFactory
class ImportExportPrefsFactory final : public PrefsPanelFactory
{
public:
virtual PrefsPanel *Create(wxWindow *parent);

6
src/prefs/KeyConfigPrefs.h
View File

@@ -34,7 +34,7 @@ class ShuttleGui;
class wxStaticText;
class KeyConfigPrefs :public PrefsPanel
class KeyConfigPrefs final : public PrefsPanel
{
public:
KeyConfigPrefs(wxWindow * parent);
@@ -102,7 +102,7 @@ private:
#include "PrefsPanel.h"
class KeyConfigPrefs:public PrefsPanel
class KeyConfigPrefs final : public PrefsPanel
{
public:
KeyConfigPrefs(wxWindow * parent);
@@ -148,7 +148,7 @@ class KeyConfigPrefs:public PrefsPanel
#endif
class KeyConfigPrefsFactory : public PrefsPanelFactory
class KeyConfigPrefsFactory final : public PrefsPanelFactory
{
public:
virtual PrefsPanel *Create(wxWindow *parent);

4
src/prefs/LibraryPrefs.h
View File

@@ -22,7 +22,7 @@
class ShuttleGui;
class LibraryPrefs :public PrefsPanel
class LibraryPrefs final : public PrefsPanel
{
public:
LibraryPrefs(wxWindow * parent);
@@ -46,7 +46,7 @@ class LibraryPrefs :public PrefsPanel
DECLARE_EVENT_TABLE();
};
class LibraryPrefsFactory : public PrefsPanelFactory
class LibraryPrefsFactory final : public PrefsPanelFactory
{
public:
virtual PrefsPanel *Create(wxWindow *parent);

4
src/prefs/MidiIOPrefs.h
View File

@@ -26,7 +26,7 @@ class ShuttleGui;
#include "PrefsPanel.h"
class MidiIOPrefs:public PrefsPanel
class MidiIOPrefs final : public PrefsPanel
{
public:
MidiIOPrefs(wxWindow * parent);
@@ -62,7 +62,7 @@ class MidiIOPrefs:public PrefsPanel
DECLARE_EVENT_TABLE();
};
class MidiIOPrefsFactory : public PrefsPanelFactory
class MidiIOPrefsFactory final : public PrefsPanelFactory
{
public:
virtual PrefsPanel *Create(wxWindow *parent);

4
src/prefs/ModulePrefs.h
View File

@@ -31,7 +31,7 @@ enum {
};
class ModulePrefs:public PrefsPanel
class ModulePrefs final : public PrefsPanel
{
public:
ModulePrefs(wxWindow * parent);
@@ -50,7 +50,7 @@ class ModulePrefs:public PrefsPanel
wxArrayString mPaths;
};
class ModulePrefsFactory : public PrefsPanelFactory
class ModulePrefsFactory final : public PrefsPanelFactory
{
public:
virtual PrefsPanel *Create(wxWindow *parent);

4
src/prefs/MousePrefs.h
View File

@@ -19,7 +19,7 @@
class ShuttleGui;
class MousePrefs :public PrefsPanel
class MousePrefs final : public PrefsPanel
{
public:
MousePrefs(wxWindow * parent);
@@ -38,7 +38,7 @@ class MousePrefs :public PrefsPanel
wxListCtrl * mList;
};
class MousePrefsFactory : public PrefsPanelFactory
class MousePrefsFactory final : public PrefsPanelFactory
{
public:
virtual PrefsPanel *Create(wxWindow *parent);

4
src/prefs/PlaybackPrefs.h
View File

@@ -20,7 +20,7 @@
class ShuttleGui;
class PlaybackPrefs :public PrefsPanel
class PlaybackPrefs final : public PrefsPanel
{
public:
PlaybackPrefs(wxWindow * parent);
@@ -32,7 +32,7 @@ class PlaybackPrefs :public PrefsPanel
void PopulateOrExchange(ShuttleGui & S);
};
class PlaybackPrefsFactory : public PrefsPanelFactory
class PlaybackPrefsFactory final : public PrefsPanelFactory
{
public:
virtual PrefsPanel *Create(wxWindow *parent);

2
src/prefs/PrefsDialog.cpp
View File

@@ -76,7 +76,7 @@ BEGIN_EVENT_TABLE(PrefsDialog, wxDialog)
END_EVENT_TABLE()
class wxTreebookExt : public wxTreebook
class wxTreebookExt final : public wxTreebook
{
public:
wxTreebookExt( wxWindow *parent,

4
src/prefs/PrefsDialog.h
View File

@@ -29,7 +29,7 @@ class PrefsPanelFactory;
#define CONST const
#endif
class PrefsDialog:public wxDialog
class PrefsDialog /* not final */ : public wxDialog
{
public:
// An array of PrefsNode specifies the tree of pages in pre-order traversal.
@@ -86,7 +86,7 @@ private:
// This adds code appropriate only to the original use of PrefsDialog for
// global settings -- not its reuses elsewhere as in View Settings
class GlobalPrefsDialog : public PrefsDialog
class GlobalPrefsDialog final : public PrefsDialog
{
public:
GlobalPrefsDialog(wxWindow * parent, Factories &factories = DefaultFactories());

4
src/prefs/PrefsPanel.h
View File

@@ -40,7 +40,7 @@ ThemePrefs.
#define TOP_LEVEL_BORDER 5
#define GENERIC_CONTROL_BORDER 5
class PrefsPanel:public wxPanel
class PrefsPanel /* not final */ : public wxPanel
{
public:
PrefsPanel(wxWindow * parent, const wxString &title)
@@ -61,7 +61,7 @@ class PrefsPanel:public wxPanel
virtual void Cancel();
};
class PrefsPanelFactory
class PrefsPanelFactory /* not final */
{
public:
// Precondition: parent != NULL

4
src/prefs/ProjectsPrefs.h
View File

@@ -21,7 +21,7 @@
class ShuttleGui;
class ProjectsPrefs :public PrefsPanel
class ProjectsPrefs final : public PrefsPanel
{
public:
ProjectsPrefs(wxWindow * parent);
@@ -33,7 +33,7 @@ class ProjectsPrefs :public PrefsPanel
void PopulateOrExchange(ShuttleGui & S);
};
class ProjectsPrefsFactory : public PrefsPanelFactory
class ProjectsPrefsFactory final : public PrefsPanelFactory
{
public:
virtual PrefsPanel *Create(wxWindow *parent);

4
src/prefs/QualityPrefs.h
View File

@@ -23,7 +23,7 @@
class ShuttleGui;
class QualityPrefs :public PrefsPanel
class QualityPrefs final : public PrefsPanel
{
public:
QualityPrefs(wxWindow * parent);
@@ -53,7 +53,7 @@ class QualityPrefs :public PrefsPanel
DECLARE_EVENT_TABLE();
};
class QualityPrefsFactory : public PrefsPanelFactory
class QualityPrefsFactory final : public PrefsPanelFactory
{
public:
virtual PrefsPanel *Create(wxWindow *parent);

4
src/prefs/RecordingPrefs.h
View File

@@ -21,7 +21,7 @@
class ShuttleGui;
class RecordingPrefs :public PrefsPanel
class RecordingPrefs final : public PrefsPanel
{
public:
RecordingPrefs(wxWindow * parent);
@@ -40,7 +40,7 @@ class RecordingPrefs :public PrefsPanel
DECLARE_EVENT_TABLE();
};
class RecordingPrefsFactory : public PrefsPanelFactory
class RecordingPrefsFactory final : public PrefsPanelFactory
{
public:
virtual PrefsPanel *Create(wxWindow *parent);

4
src/prefs/SpectrogramSettings.cpp
View File

@@ -144,7 +144,7 @@ SpectrogramSettings& SpectrogramSettings::defaults()
//static
const wxArrayString &SpectrogramSettings::GetScaleNames()
{
class ScaleNamesArray : public TranslatableStringArray
class ScaleNamesArray final : public TranslatableStringArray
{
virtual void Populate()
{
@@ -169,7 +169,7 @@ const wxArrayString &SpectrogramSettings::GetScaleNames()
//static
const wxArrayString &SpectrogramSettings::GetAlgorithmNames()
{
class AlgorithmNamesArray : public TranslatableStringArray
class AlgorithmNamesArray final : public TranslatableStringArray
{
virtual void Populate()
{

4
src/prefs/SpectrumPrefs.h
View File

@@ -38,7 +38,7 @@ class ShuttleGui;
class SpectrogramSettings;
class WaveTrack;
class SpectrumPrefs:public PrefsPanel
class SpectrumPrefs final : public PrefsPanel
{
public:
SpectrumPrefs(wxWindow * parent, WaveTrack *wt);
@@ -96,7 +96,7 @@ class SpectrumPrefs:public PrefsPanel
bool mPopulating;
};
class SpectrumPrefsFactory : public PrefsPanelFactory
class SpectrumPrefsFactory final : public PrefsPanelFactory
{
public:
explicit SpectrumPrefsFactory(WaveTrack *wt = 0);

4
src/prefs/ThemePrefs.h
View File

@@ -21,7 +21,7 @@
class ShuttleGui;
class ThemePrefs :public PrefsPanel
class ThemePrefs final : public PrefsPanel
{
public:
ThemePrefs(wxWindow * parent);
@@ -41,7 +41,7 @@ class ThemePrefs :public PrefsPanel
DECLARE_EVENT_TABLE();
};
class ThemePrefsFactory : public PrefsPanelFactory
class ThemePrefsFactory final : public PrefsPanelFactory
{
public:
virtual PrefsPanel *Create(wxWindow *parent);

4
src/prefs/TracksPrefs.h
View File

@@ -22,7 +22,7 @@
class ShuttleGui;
class TracksPrefs :public PrefsPanel
class TracksPrefs final : public PrefsPanel
{
public:
TracksPrefs(wxWindow * parent);
@@ -39,7 +39,7 @@ class TracksPrefs :public PrefsPanel
wxArrayString mViewChoices;
};
class TracksPrefsFactory : public PrefsPanelFactory
class TracksPrefsFactory final : public PrefsPanelFactory
{
public:
virtual PrefsPanel *Create(wxWindow *parent);

4
src/prefs/WarningsPrefs.h
View File

@@ -21,7 +21,7 @@
class ShuttleGui;
class WarningsPrefs :public PrefsPanel
class WarningsPrefs final : public PrefsPanel
{
public:
WarningsPrefs(wxWindow * parent);
@@ -33,7 +33,7 @@ class WarningsPrefs :public PrefsPanel
void PopulateOrExchange(ShuttleGui & S);
};
class WarningsPrefsFactory : public PrefsPanelFactory
class WarningsPrefsFactory final : public PrefsPanelFactory
{
public:
virtual PrefsPanel *Create(wxWindow *parent);

4
src/prefs/WaveformPrefs.h
View File

@@ -20,7 +20,7 @@ class WaveTrack;
class wxCheckBox;
class wxChoice;
class WaveformPrefs :public PrefsPanel
class WaveformPrefs final : public PrefsPanel
{
public:
WaveformPrefs(wxWindow * parent, WaveTrack *wt);
@@ -56,7 +56,7 @@ private:
bool mPopulating;
};
class WaveformPrefsFactory : public PrefsPanelFactory
class WaveformPrefsFactory final : public PrefsPanelFactory
{
public:
explicit WaveformPrefsFactory(WaveTrack *wt = 0);

2
src/prefs/WaveformSettings.cpp
View File

@@ -149,7 +149,7 @@ void WaveformSettings::NextHigherDBRange()
//static
const wxArrayString &WaveformSettings::GetScaleNames()
{
class ScaleNamesArray : public TranslatableStringArray
class ScaleNamesArray final : public TranslatableStringArray
{
virtual void Populate()
{