Harmlessly qualify classes as final (or explicitly comment not)...

... Should have no effect on generated code, except perhaps some slight faster
virtual function calls.  Mostly useful as documentation of design intent.

Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.

src/export/Export.h

@@ -50,7 +50,7 @@ WX_DECLARE_USER_EXPORTED_OBJARRAY(FormatInfo, FormatInfoArray, AUDACITY_DLL_API)
 //----------------------------------------------------------------------------
 // ExportPlugin
 //----------------------------------------------------------------------------
-class AUDACITY_DLL_API ExportPlugin
+class AUDACITY_DLL_API ExportPlugin /* not final */
 {
 public:
 
@@ -131,7 +131,7 @@ WX_DEFINE_USER_EXPORTED_ARRAY_PTR(wxWindow *, WindowPtrArray, class AUDACITY_DLL
 //----------------------------------------------------------------------------
 // Exporter
 //----------------------------------------------------------------------------
-class  AUDACITY_DLL_API Exporter : public wxEvtHandler
+class  AUDACITY_DLL_API Exporter final : public wxEvtHandler
 {
 public:
 
@@ -195,7 +195,7 @@ private:
 //----------------------------------------------------------------------------
 // ExportMixerPanel
 //----------------------------------------------------------------------------
-class ExportMixerPanel: public wxPanel
+class ExportMixerPanel final : public wxPanel
 {
 public:
    ExportMixerPanel( MixerSpec *mixerSpec, wxArrayString trackNames,
@@ -228,7 +228,7 @@ private:
 //----------------------------------------------------------------------------
 // ExportMixerDialog
 //----------------------------------------------------------------------------
-class ExportMixerDialog : public wxDialog
+class ExportMixerDialog final : public wxDialog
 {
 public:
    // constructors and destructors

src/export/ExportCL.cpp

@@ -39,7 +39,7 @@
 // ExportCLOptions
 //----------------------------------------------------------------------------
 
-class ExportCLOptions : public wxPanel
+class ExportCLOptions final : public wxPanel
 {
 public:
    ExportCLOptions(wxWindow *parent, int format);
@@ -206,7 +206,7 @@ static void Drain(wxInputStream *s, wxString *o)
    }
 }
 
-class ExportCLProcess : public wxProcess
+class ExportCLProcess final : public wxProcess
 {
 public:
    ExportCLProcess(wxString *output)
@@ -274,7 +274,7 @@ struct wav_header {
    wxUint32 dataLen;          /* length of all samples in bytes */
 };
 
-class ExportCL : public ExportPlugin
+class ExportCL final : public ExportPlugin
 {
 public:
 

src/export/ExportFFmpeg.cpp

@@ -90,7 +90,7 @@ static int AdjustFormatIndex(int format)
 // ExportFFmpeg
 //----------------------------------------------------------------------------
 
-class ExportFFmpeg : public ExportPlugin
+class ExportFFmpeg final : public ExportPlugin
 {
 public:
 

src/export/ExportFFmpegDialogs.h

@@ -58,7 +58,7 @@ struct CompatibilityEntry
 
 
 /// AC3 export options dialog
-class ExportFFmpegAC3Options : public wxPanel
+class ExportFFmpegAC3Options final : public wxPanel
 {
 public:
 
@@ -84,7 +84,7 @@ private:
    int mBitRateFromChoice;
 };
 
-class ExportFFmpegAACOptions : public wxPanel
+class ExportFFmpegAACOptions final : public wxPanel
 {
 public:
 
@@ -100,7 +100,7 @@ private:
    wxSpinCtrl *mQualitySpin;
 };
 
-class ExportFFmpegAMRNBOptions : public wxPanel
+class ExportFFmpegAMRNBOptions final : public wxPanel
 {
 public:
 
@@ -122,7 +122,7 @@ private:
    int mBitRateFromChoice;
 };
 
-class ExportFFmpegWMAOptions : public wxPanel
+class ExportFFmpegWMAOptions final : public wxPanel
 {
 public:
 
@@ -145,7 +145,7 @@ private:
    int mBitRateFromChoice;
 };
 
-class ExportFFmpegCustomOptions : public wxPanel
+class ExportFFmpegCustomOptions final : public wxPanel
 {
 public:
 
@@ -175,7 +175,7 @@ struct ApplicableFor
 class FFmpegPresets;
 
 /// Custom FFmpeg export dialog
-class ExportFFmpegOptions : public wxDialog
+class ExportFFmpegOptions final : public wxDialog
 {
 public:
 

src/export/ExportFLAC.cpp

@@ -47,7 +47,7 @@ and libvorbis examples, Monty <monty@xiph.org>
 // ExportFLACOptions Class
 //----------------------------------------------------------------------------
 
-class ExportFLACOptions : public wxPanel
+class ExportFLACOptions final : public wxPanel
 {
 public:
 
@@ -173,7 +173,7 @@ static struct
 
 //----------------------------------------------------------------------------
 
-class ExportFLAC : public ExportPlugin
+class ExportFLAC final : public ExportPlugin
 {
 public:
 

src/export/ExportMP2.cpp

@@ -82,7 +82,7 @@ static int iBitrates[] = {
    192, 224, 256, 320, 384
 };
 
-class ExportMP2Options : public wxPanel
+class ExportMP2Options final : public wxPanel
 {
 public:
    ExportMP2Options(wxWindow *parent, int format);
@@ -164,7 +164,7 @@ bool ExportMP2Options::TransferDataFromWindow()
 // ExportMP2
 //----------------------------------------------------------------------------
 
-class ExportMP2 : public ExportPlugin
+class ExportMP2 final : public ExportPlugin
 {
 public:
 

src/export/ExportMP3.cpp

@@ -259,7 +259,7 @@ static void InitMP3_Statics()
    }
 }
 
-class ExportMP3Options : public wxPanel
+class ExportMP3Options final : public wxPanel
 {
 public:
 
@@ -556,7 +556,7 @@ int ExportMP3Options::FindIndex(CHOICES *choices, int cnt, int needle, int def)
 #define ID_BROWSE 5000
 #define ID_DLOAD  5001
 
-class FindDialog : public wxDialog
+class FindDialog final : public wxDialog
 {
 public:
 
@@ -1551,7 +1551,7 @@ static void dump_config( 	lame_global_flags*	gfp )
 // ExportMP3
 //----------------------------------------------------------------------------
 
-class ExportMP3 : public ExportPlugin
+class ExportMP3 final : public ExportPlugin
 {
 public:
 

src/export/ExportMultiple.h

@@ -31,7 +31,7 @@ class LabelTrack;
 class ShuttleGui;
 class TrackListIterator;
 
-class ExportMultiple : public wxDialog
+class ExportMultiple final : public wxDialog
 {
 public:
 
@@ -169,7 +169,7 @@ private:
 
 };
 
-class SuccessDialog : public wxDialog
+class SuccessDialog final : public wxDialog
 {
 public:
    SuccessDialog(wxWindow *parent, wxWindowID id, const wxString &title) :
@@ -181,7 +181,7 @@ private:
    DECLARE_EVENT_TABLE()
 };
 
-class MouseEvtHandler : public wxEvtHandler
+class MouseEvtHandler final : public wxEvtHandler
 {
 public:
    void OnMouse(wxMouseEvent& event);

src/export/ExportOGG.cpp

@@ -42,7 +42,7 @@
 // ExportOGGOptions
 //----------------------------------------------------------------------------
 
-class ExportOGGOptions : public wxPanel
+class ExportOGGOptions final : public wxPanel
 {
 public:
 
@@ -123,7 +123,7 @@ bool ExportOGGOptions::TransferDataFromWindow()
 
 #define SAMPLES_PER_RUN 8192
 
-class ExportOGG : public ExportPlugin
+class ExportOGG final : public ExportPlugin
 {
 public:
 

src/export/ExportPCM.cpp

@@ -92,7 +92,7 @@ static void WriteExportFormatPref(int format)
 #define ID_HEADER_CHOICE           7102
 #define ID_ENCODING_CHOICE         7103
 
-class ExportPCMOptions : public wxPanel
+class ExportPCMOptions final : public wxPanel
 {
 public:
 
@@ -303,7 +303,7 @@ bool ExportPCMOptions::ValidatePair(int format)
 // ExportPCM Class
 //----------------------------------------------------------------------------
 
-class ExportPCM : public ExportPlugin
+class ExportPCM final : public ExportPlugin
 {
 public: