Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-11-08 22:23:59 +01:00
Code Issues Releases Wiki Activity

Harmlessly qualify classes as final (or explicitly comment not)...

Browse Source 
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls.  Mostly useful as documentation of design intent.

Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
This commit is contained in:
Paul Licameli
2016-02-24 01:06:39 -05:00
parent e2f7e5f6f6
commit 7824e94030
261 changed files with 480 additions and 472 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/effects/audiounits/AUControl.h
View File

@@ -20,14 +20,14 @@
#include <AudioUnit/AudioComponent.h>
class AUControlImpl : public wxWidgetCocoaImpl
class AUControlImpl final : public wxWidgetCocoaImpl
{
public :
AUControlImpl(wxWindowMac *peer, NSView *view);
~AUControlImpl();
};
class AUControl : public wxControl
class AUControl final : public wxControl
{
public:
AUControl();

6
src/effects/audiounits/AudioUnitEffect.cpp
View File

@@ -286,7 +286,7 @@ OSType AudioUnitEffectsModule::ToOSType(const wxString & type)
//
///////////////////////////////////////////////////////////////////////////////
class AudioUnitEffectOptionsDialog:public wxDialog
class AudioUnitEffectOptionsDialog final : public wxDialog
{
public:
AudioUnitEffectOptionsDialog(wxWindow * parent, EffectHostInterface *host);
@@ -426,7 +426,7 @@ void AudioUnitEffectOptionsDialog::OnOk(wxCommandEvent & WXUNUSED(evt))
#define PRESET_LOCAL_PATH wxT("/Library/Audio/Presets")
#define PRESET_USER_PATH wxT("~/Library/Audio/Presets")
class AudioUnitEffectExportDialog:public wxDialog
class AudioUnitEffectExportDialog final : public wxDialog
{
public:
AudioUnitEffectExportDialog(wxWindow * parent, AudioUnitEffect *effect);
@@ -600,7 +600,7 @@ void AudioUnitEffectExportDialog::OnOk(wxCommandEvent & WXUNUSED(evt))
//
///////////////////////////////////////////////////////////////////////////////
class AudioUnitEffectImportDialog:public wxDialog
class AudioUnitEffectImportDialog final : public wxDialog
{
public:
AudioUnitEffectImportDialog(wxWindow * parent, AudioUnitEffect *effect);

2
src/effects/audiounits/AudioUnitEffect.h
View File

@@ -221,7 +221,7 @@ private:
//
///////////////////////////////////////////////////////////////////////////////
class AudioUnitEffectsModule : public ModuleInterface
class AudioUnitEffectsModule final : public ModuleInterface
{
public:
AudioUnitEffectsModule(ModuleManagerInterface *moduleManager, const wxString *path);