1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-11-23 17:30:17 +01:00

Harmlessly qualify classes as final (or explicitly comment not)...

... Should have no effect on generated code, except perhaps some slight faster
virtual function calls.  Mostly useful as documentation of design intent.

Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
This commit is contained in:
Paul Licameli
2016-02-24 01:06:39 -05:00
parent e2f7e5f6f6
commit 7824e94030
261 changed files with 480 additions and 472 deletions

View File

@@ -31,7 +31,7 @@
// MixerTrackSlider is a subclass just to override OnMouseEvent,
// so we can know when adjustment ends, so we can PushState only then.
class MixerTrackSlider : public ASlider
class MixerTrackSlider final : public ASlider
{
public:
MixerTrackSlider(wxWindow * parent,
@@ -68,7 +68,7 @@ class NoteTrack;
#endif
class WaveTrack;
class MixerTrackCluster : public wxPanel
class MixerTrackCluster final : public wxPanel
{
public:
MixerTrackCluster(wxWindow* parent,
@@ -169,7 +169,7 @@ WX_DECLARE_OBJARRAY(MusicalInstrument, MusicalInstrumentArray);
// wxScrolledWindow ignores mouse clicks in client area,
// but they don't get passed to Mixerboard.
// We need to catch them to deselect all track clusters.
class MixerBoardScrolledWindow : public wxScrolledWindow
class MixerBoardScrolledWindow final : public wxScrolledWindow
{
public:
MixerBoardScrolledWindow(AudacityProject* project,
@@ -194,7 +194,7 @@ public:
class MixerBoardFrame;
class TrackList;
class MixerBoard : public wxWindow
class MixerBoard final : public wxWindow
{
friend class MixerBoardFrame;
@@ -301,7 +301,7 @@ public:
};
class MixerBoardFrame : public wxFrame
class MixerBoardFrame final : public wxFrame
{
public:
MixerBoardFrame(AudacityProject* parent);