1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-10-22 22:43:01 +02:00

Harmlessly qualify classes as final (or explicitly comment not)...

... Should have no effect on generated code, except perhaps some slight faster
virtual function calls.  Mostly useful as documentation of design intent.

Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
This commit is contained in:
Paul Licameli
2016-02-24 01:06:39 -05:00
parent e2f7e5f6f6
commit 7824e94030
261 changed files with 480 additions and 472 deletions

View File

@@ -44,7 +44,7 @@
#include "audacity/Types.h"
class AUDACITY_DLL_API ConfigClientInterface
class AUDACITY_DLL_API ConfigClientInterface /* not final */
{
public:
virtual ~ConfigClientInterface() {};

View File

@@ -58,7 +58,7 @@ typedef enum EffectType
EffectTypeAnalyze
} EffectType;
class AUDACITY_DLL_API EffectIdentInterface : public IdentInterface
class AUDACITY_DLL_API EffectIdentInterface /* not final */ : public IdentInterface
{
public:
virtual ~EffectIdentInterface() {};
@@ -88,7 +88,7 @@ public:
class EffectUIHostInterface;
class EffectUIClientInterface;
class AUDACITY_DLL_API EffectHostInterface : public ConfigClientInterface
class AUDACITY_DLL_API EffectHostInterface /* not final */ : public ConfigClientInterface
{
public:
virtual ~EffectHostInterface() {};
@@ -110,7 +110,7 @@ public:
virtual wxString GetFactoryDefaultsGroup() = 0;
};
class AUDACITY_DLL_API EffectClientInterface : public EffectIdentInterface
class AUDACITY_DLL_API EffectClientInterface /* not final */ : public EffectIdentInterface
{
public:
virtual ~EffectClientInterface() {};
@@ -162,7 +162,7 @@ public:
virtual ~EffectUIHostInterface() {};
};
class AUDACITY_DLL_API EffectUIClientInterface
class AUDACITY_DLL_API EffectUIClientInterface /* not final */
{
public:
virtual ~EffectUIClientInterface() {};

View File

@@ -44,7 +44,7 @@
#include "audacity/Types.h"
class AUDACITY_DLL_API IdentInterface
class AUDACITY_DLL_API IdentInterface /* not final */
{
public:
virtual ~IdentInterface() {};

View File

@@ -61,7 +61,7 @@
//
// ============================================================================
class ModuleInterface : public IdentInterface
class ModuleInterface /* not final */ : public IdentInterface
{
public:
virtual ~ModuleInterface() {};
@@ -106,7 +106,7 @@ public:
//
// ============================================================================
class ModuleManagerInterface
class ModuleManagerInterface /* not final */
{
public:
virtual ~ModuleManagerInterface() {};

View File

@@ -51,7 +51,7 @@
class ModuleInterface;
class PluginManagerInterface
class PluginManagerInterface /* not final */
{
public:
virtual ~PluginManagerInterface() {};