From 712287726994142ea2c4f0e08831d999b5e2914e Mon Sep 17 00:00:00 2001
From: James Crook <james.k.crook@gmail.com>
Date: Tue, 30 May 2017 12:38:25 +0100
Subject: [PATCH] Fix crash from bad SelectionToolbarMode

When out of range, it was indexing outside an array.  Now forced to be in range.
---
 src/toolbars/SelectionBar.cpp | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/src/toolbars/SelectionBar.cpp b/src/toolbars/SelectionBar.cpp
index dc4d60cec..050acedcf 100644
--- a/src/toolbars/SelectionBar.cpp
+++ b/src/toolbars/SelectionBar.cpp
@@ -142,7 +142,16 @@ SelectionBar::SelectionBar()
    // Audacity to fail.
    mRate = (double) gPrefs->Read(wxT("/SamplingRate/DefaultProjectSampleRate"),
       AudioIO::GetOptimalSupportedSampleRate());
-   
+
+#ifdef SEL_BUTTON_TITLES
+   mButtonTitles[0]=NULL;
+   mButtonTitles[1]=NULL;
+   mButtonTitles[2]=NULL; 
+#endif
+   mHyphen[0]=NULL;
+   mHyphen[1]=NULL;
+   mHyphen[2]=NULL;
+
    // Selection mode of 0 means showing 'start' and 'end' only.
    mSelectionMode = gPrefs->ReadLong(wxT("/SelectionToolbarMode"),  0);
 }
@@ -752,6 +761,18 @@ void SelectionBar::SelectionModeUpdated()
 
 void SelectionBar::SetSelectionMode(int mode)
 {
+#ifdef SEL_BUTTON_TITLES
+   // With SEL_BUTTON_TITLES only modes 0 to 3 are supported,
+   // so fix up a mode that could have come from the config.
+   const int maxMode = 3;
+#else 
+   const int maxMode = 7;
+#endif
+
+   if( mode > maxMode )
+      mode = 0;
+   if( mode < 0 )
+      mode = 0;
    mSelectionMode = mode;
 
    int id = mode + StartEndRadioID;