From 668bcfc82e56ae5c4715964e52acad73fef2569b Mon Sep 17 00:00:00 2001 From: Leland Lucius Date: Sun, 8 Mar 2020 23:18:51 -0500 Subject: [PATCH] Bug 2315 - Mac: Keyboard Preferences is unusable until scrolled. Second attempt with this bug. I see a pattern emerging for my "fixes"!!! :-( --- src/prefs/ExtImportPrefs.cpp | 8 +++++--- src/prefs/KeyConfigPrefs.cpp | 5 ++++- src/prefs/MousePrefs.cpp | 5 ++++- 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/src/prefs/ExtImportPrefs.cpp b/src/prefs/ExtImportPrefs.cpp index 3b7b8a7a1..1e7b5cece 100644 --- a/src/prefs/ExtImportPrefs.cpp +++ b/src/prefs/ExtImportPrefs.cpp @@ -221,9 +221,11 @@ bool ExtImportPrefs::Commit() void ExtImportPrefs::OnShow(wxShowEvent &event) { event.Skip(); - - RuleTable->Refresh(); - PluginList->Refresh(); + if (event.IsShown()) + { + RuleTable->Refresh(); + PluginList->Refresh(); + } } void ExtImportPrefs::OnPluginKeyDown(wxListEvent& event) diff --git a/src/prefs/KeyConfigPrefs.cpp b/src/prefs/KeyConfigPrefs.cpp index c05ec3964..65f80a25e 100644 --- a/src/prefs/KeyConfigPrefs.cpp +++ b/src/prefs/KeyConfigPrefs.cpp @@ -469,7 +469,10 @@ void KeyConfigPrefs::OnShow(wxShowEvent & event) { event.Skip(); - mView->Refresh(); + if (event.IsShown()) + { + mView->Refresh(); + } } void KeyConfigPrefs::OnImport(wxCommandEvent & WXUNUSED(event)) diff --git a/src/prefs/MousePrefs.cpp b/src/prefs/MousePrefs.cpp index d410b6748..9f15f5305 100644 --- a/src/prefs/MousePrefs.cpp +++ b/src/prefs/MousePrefs.cpp @@ -221,7 +221,10 @@ void MousePrefs::OnShow(wxShowEvent &event) { event.Skip(); - mList->Refresh(); + if (event.IsShown()) + { + mList->Refresh(); + } } /// Update the preferences stored on disk.