Changes to a number of dialogs so that the nvda screen reader can read their titles. The accessibility name of the dialog is set to the title of the dialog.

src/AboutDialog.cpp

@@ -177,6 +177,7 @@ AboutDialog::AboutDialog(wxWindow * parent)
                wxDefaultPosition, wxDefaultSize,
                wxDEFAULT_DIALOG_STYLE | wxRESIZE_BORDER)
 {
+   SetName(GetTitle());
    this->SetBackgroundColour(theTheme.Colour( clrAboutBoxBackground ));
    icon = NULL;
    ShuttleGui S( this, eIsCreating );

src/AudacityApp.cpp

@@ -1056,6 +1056,7 @@ void AudacityApp::GenerateCrashReport(wxDebugReport::Context ctx)
                               _("Audacity Support Data"),
                               rpt.GetCompressedFileName(),
                               wxOK | wxCENTER);
+      dlg.SetName(dlg.GetTitle());
       dlg.ShowModal();
 
       wxLogMessage(wxT("Report generated to: %s"),

src/AudacityLogger.cpp

@@ -165,6 +165,7 @@ void AudacityLogger::Show(bool show)
 
    // This is the first use, so create the frame
    wxFrame *frame = new wxFrame(NULL, wxID_ANY, _("Audacity Log"));
+   frame->SetName(frame->GetTitle());
    frame->SetBackgroundColour(wxSystemSettings::GetColour(wxSYS_COLOUR_3DFACE));
 
    // loads either the XPM or the windows resource, depending on the platform

src/FreqWindow.cpp

@@ -200,6 +200,8 @@ FreqWindow::FreqWindow(wxWindow * parent, wxWindowID id,
    mBitmap(NULL),
    mAnalyst(new SpectrumAnalyst())
 {
+   SetName(GetTitle());
+
    mMouseX = 0;
    mMouseY = 0;
    mRate = 0;

src/HistoryWindow.cpp

@@ -54,6 +54,8 @@ HistoryWindow::HistoryWindow(AudacityProject *parent, UndoManager *manager):
       wxDefaultPosition, wxDefaultSize,
       wxDEFAULT_DIALOG_STYLE | wxRESIZE_BORDER )
 {
+   SetName(GetTitle());
+
    mManager = manager;
    mProject = parent;
    mSelected = 0;

src/LabelDialog.cpp

@@ -105,6 +105,8 @@ LabelDialog::LabelDialog(wxWindow *parent,
   mRate(rate),
   mFormat(format)
 {
+   SetName(GetTitle());
+
    // Create the main sizer
    wxBoxSizer *vs = new wxBoxSizer(wxVERTICAL);
 

src/Menus.cpp

@@ -6356,6 +6356,7 @@ void AudacityProject::OnAudioDeviceInfo()
    wxString info = gAudioIO->GetDeviceInfo();
 
    wxDialog dlg(this, wxID_ANY, wxString(_("Audio Device Info")));
+   dlg.SetName(dlg.GetTitle());
    ShuttleGui S(&dlg, eIsCreating);
 
    wxTextCtrl *text;
@@ -6488,6 +6489,7 @@ void AudacityProject::OnResample()
    while (true)
    {
       wxDialog dlg(this, wxID_ANY, wxString(_("Resample")));
+      dlg.SetName(dlg.GetTitle());
       ShuttleGui S(&dlg, eIsCreating);
       wxString rate;
       wxArrayString rates;

src/Tags.cpp

@@ -664,6 +664,8 @@ TagsEditor::TagsEditor(wxWindow * parent,
    mEditTitle(editTitle),
    mEditTrack(editTrack)
 {
+   SetName(GetTitle());
+
    names[0] = LABEL_ARTIST;
    names[1] = LABEL_TITLE;
    names[2] = LABEL_ALBUM;

src/TimerRecordDialog.cpp

@@ -70,6 +70,8 @@ TimerRecordDialog::TimerRecordDialog(wxWindow* parent)
 : wxDialog(parent, -1, _("Audacity Timer Record"), wxDefaultPosition,
            wxDefaultSize, wxCAPTION)
 {
+   SetName(GetTitle());
+
    m_DateTime_Start = wxDateTime::UNow();
    long seconds; // default duration is 1 hour = 3600 seconds
    gPrefs->Read(wxT("/TimerRecord/LastDuration"), &seconds, 3600);

src/effects/Contrast.cpp

@@ -227,6 +227,8 @@ ContrastDialog::ContrastDialog(wxWindow * parent, wxWindowID id,
   wxDialog(parent, id, title, pos, wxDefaultSize,
      wxDEFAULT_DIALOG_STYLE | wxRESIZE_BORDER | wxMAXIMIZE_BOX )
 {
+   SetName(GetTitle());
+
    foregrounddB = 1234.0;
    backgrounddB = 1234.0;
 

src/import/ImportPCM.cpp

@@ -236,6 +236,7 @@ static wxString AskCopyOrEdit()
    if (oldAskPref) {
       wxString newCopyPref = wxT("copy");
       wxDialog dialog(NULL, -1, wxString(_("Warning")));
+      dialog.SetName(dialog.GetTitle());
 
       wxBoxSizer *vbox = new wxBoxSizer(wxVERTICAL);
       dialog.SetSizer(vbox);

src/prefs/PrefsDialog.cpp

@@ -92,6 +92,7 @@ int wxTreebookExt::ChangeSelection(size_t n) {
    int i = wxTreebook::ChangeSelection(n);
    wxString Temp = GetPageText( n );
    ((wxDialog*)GetParent())->SetTitle( Temp );
+   ((wxDialog*)GetParent())->SetName( Temp );
    return i;
 };
 
@@ -100,6 +101,7 @@ int wxTreebookExt::SetSelection(size_t n)
    int i = wxTreebook::SetSelection(n);
    wxString Temp = wxString(_("Preferences: ")) + GetPageText( n );
    ((wxDialog*)GetParent())->SetTitle( Temp );
+   ((wxDialog*)GetParent())->SetName( Temp );
    return i;
 }
 

src/widgets/Warning.cpp

@@ -56,6 +56,8 @@ WarningDialog::WarningDialog(wxWindow *parent, wxString message, bool showCancel
             wxDefaultPosition, wxDefaultSize,
             (showCancelButton ? wxDEFAULT_DIALOG_STYLE : wxCAPTION | wxSYSTEM_MENU)) // Unlike wxDEFAULT_DIALOG_STYLE, no wxCLOSE_BOX.
 {
+   SetName(GetTitle());
+
    SetIcon(wxArtProvider::GetIcon(wxART_WARNING, wxART_MESSAGE_BOX));
    ShuttleGui S(this, eIsCreating);