Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-12-24 09:31:13 +01:00
Code Issues Releases Wiki Activity

Sweep unnecessary wxString copies: blockfile

Browse Source
This commit is contained in:
Paul Licameli
2016-02-22 21:18:00 -05:00
parent 923a6ce4af
commit 6597575f6a
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/blockfile/LegacyAliasBlockFile.cpp
View File

@@ -81,7 +81,7 @@ void LegacyAliasBlockFile::SaveXML(XMLWriter &xmlFile)
// BuildFromXML methods should always return a BlockFile, not NULL, // BuildFromXML methods should always return a BlockFile, not NULL,
// even if the result is flawed (e.g., refers to nonexistent file), // even if the result is flawed (e.g., refers to nonexistent file),
// as testing will be done in DirManager::ProjectFSCK(). // as testing will be done in DirManager::ProjectFSCK().
BlockFile *LegacyAliasBlockFile::BuildFromXML(wxString projDir, const wxChar **attrs) BlockFile *LegacyAliasBlockFile::BuildFromXML(const wxString &projDir, const wxChar **attrs)
{ {
wxFileName summaryFileName; wxFileName summaryFileName;
wxFileName aliasFileName; wxFileName aliasFileName;

2
src/blockfile/LegacyAliasBlockFile.h
View File

@@ -35,7 +35,7 @@ class LegacyAliasBlockFile : public PCMAliasBlockFile
virtual BlockFile *Copy(wxFileName fileName); virtual BlockFile *Copy(wxFileName fileName);
virtual void Recover(); virtual void Recover();
static BlockFile *BuildFromXML(wxString projDir, const wxChar **attrs); static BlockFile *BuildFromXML(const wxString &projDir, const wxChar **attrs);
}; };
#endif #endif

2
src/blockfile/LegacyBlockFile.cpp
View File

@@ -284,7 +284,7 @@ void LegacyBlockFile::SaveXML(XMLWriter &xmlFile)
// even if the result is flawed (e.g., refers to nonexistent file), // even if the result is flawed (e.g., refers to nonexistent file),
// as testing will be done in DirManager::ProjectFSCK(). // as testing will be done in DirManager::ProjectFSCK().
/// static /// static
BlockFile *LegacyBlockFile::BuildFromXML(wxString projDir, const wxChar **attrs, BlockFile *LegacyBlockFile::BuildFromXML(const wxString &projDir, const wxChar **attrs,
sampleCount len, sampleFormat format) sampleCount len, sampleFormat format)
{ {
wxFileName fileName; wxFileName fileName;

2
src/blockfile/LegacyBlockFile.h
View File

@@ -60,7 +60,7 @@ class LegacyBlockFile : public BlockFile {
virtual wxLongLong GetSpaceUsage(); virtual wxLongLong GetSpaceUsage();
virtual void Recover(); virtual void Recover();
static BlockFile *BuildFromXML(wxString dir, const wxChar **attrs, static BlockFile *BuildFromXML(const wxString &dir, const wxChar **attrs,
sampleCount len, sampleCount len,
sampleFormat format); sampleFormat format);