Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-05-02 16:49:41 +02:00
Code Issues Releases Wiki Activity

Remove NormalizeOnLoad

Browse Source 
It's a mis-feature.
This commit is contained in:
James Crook 2019-08-02 18:09:05 +01:00
parent 5ebc13be93
commit 65682e7a0c
4 changed files with 2 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/ProjectFileManager.cpp
View File

@ -1711,18 +1711,6 @@ bool ProjectFileManager::Import(
}
}
int mode = gPrefs->Read(wxT("/AudioFiles/NormalizeOnLoad"), 0L);
if (mode == 1) {
//TODO: All we want is a SelectAll()
SelectUtilities::SelectNone( project );
SelectUtilities::SelectAllIfNone( project );
const CommandContext context( project );
EffectManager::DoEffect(
EffectManager::Get().GetEffectByIdentifier(wxT("Normalize")),
context,
EffectManager::kConfigured);
}
// This is a no-fail:
dirManager.FillBlockfilesCache();
return true;

1
src/ProjectSettings.cpp
View File

@ -89,7 +89,6 @@ ProjectSettings::ProjectSettings( AudacityProject &project )
void ProjectSettings::UpdatePrefs()
{
gPrefs->Read(wxT("/AudioFiles/ShowId3Dialog"), &mShowId3Dialog, true);
gPrefs->Read(wxT("/AudioFiles/NormalizeOnLoad"),&mNormalizeOnLoad, false);
gPrefs->Read(wxT("/GUI/EmptyCanBeDirty"), &mEmptyCanBeDirty, true );
gPrefs->Read(wxT("/GUI/ShowSplashScreen"), &mShowSplashScreen, true);
gPrefs->Read(wxT("/GUI/Solo"), &mSoloPref, wxT("Simple"));

4
src/ProjectSettings.h
View File

@ -75,9 +75,6 @@ public:
bool GetShowId3Dialog() const { return mShowId3Dialog; } //lda
void SetShowId3Dialog(bool flag) { mShowId3Dialog = flag; } //lda
bool GetNormalizeOnLoad() const { return mNormalizeOnLoad; } //lda
void SetNormalizeOnLoad(bool flag) { mNormalizeOnLoad = flag; } //lda
bool IsSyncLocked() const;
void SetSyncLock(bool flag);
@ -141,7 +138,6 @@ private:
bool mTracksFitVerticallyZoomed{ false }; //lda
bool mShowId3Dialog{ true }; //lda
bool mNormalizeOnLoad; //lda
bool mIsSyncLocked{ false };
bool mEmptyCanBeDirty;
bool mShowSplashScreen;

9
src/prefs/ImportExportPrefs.cpp
View File

@ -65,9 +65,9 @@ void ImportExportPrefs::PopulateOrExchange(ShuttleGui & S)
S.SetBorder(2);
S.StartScroller();
#ifdef EXPERIMENTAL_OD_DATA
S.StartStatic(_("When importing audio files"));
{
#ifdef EXPERIMENTAL_OD_DATA
S.StartRadioButtonGroup(wxT("/FileFormats/CopyOrEditUncompressedData"), wxT("copy"));
{
S.TieRadioButton(_("&Copy uncompressed files into the project (safer)"),
@ -76,14 +76,9 @@ void ImportExportPrefs::PopulateOrExchange(ShuttleGui & S)
wxT("edit"));
}
S.EndRadioButtonGroup();
#endif
S.TieCheckBox(_("&Normalize all tracks in project"),
wxT("/AudioFiles/NormalizeOnLoad"),
false);
}
S.EndStatic();
#endif
S.StartStatic(_("When exporting tracks to an audio file"));
{
S.StartRadioButtonGroup(wxT("/FileFormats/ExportDownMix"), true);