1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-07-24 00:18:07 +02:00

Don't hide macros GUI when applying.

This commit is contained in:
James Crook 2018-03-19 17:38:18 +00:00
parent a02c9de789
commit 63879f2fc4

View File

@ -259,13 +259,10 @@ void ApplyMacroDialog::ApplyMacroToProject( int iMacro, bool bHasGui )
// Without this the newly created dialog may not show completely. // Without this the newly created dialog may not show completely.
wxYield(); wxYield();
// The Hide() on the next line seems to tickle a bug in wx3, //Since we intend to keep this dialog open, there is no reason to hide it
// giving rise to our Bug #1221. The problem is that on Linux //and then show it again.
// the 'Hide' converts us from a Modal into a regular dialog, //if( bHasGui )
// as far as closing is concerned. On Linux we can't close with // Hide();
// EndModal() anymore after this.
if( bHasGui )
Hide();
gPrefs->Write(wxT("/Batch/ActiveMacro"), name); gPrefs->Write(wxT("/Batch/ActiveMacro"), name);
gPrefs->Flush(); gPrefs->Flush();
@ -424,6 +421,8 @@ void ApplyMacroDialog::OnApplyToFiles(wxCommandEvent & WXUNUSED(event))
// Without this the newly created dialog may not show completely. // Without this the newly created dialog may not show completely.
wxYield(); wxYield();
// We could avoid hiding, but there are many dialogs on screen,
// and hiding this one temporarily has some advantages.
Hide(); Hide();
mMacroCommands.ReadMacro(name); mMacroCommands.ReadMacro(name);