Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2026-01-12 15:45:54 +01:00
Code Issues Releases Wiki Activity

KeyView: fix focus issue

Browse Source 
Problem: A user can tab to the list, and none of the items is the focus. The list itself is still the focus. As a result, there is no visual indication of the focus, and an additional keystroke is needed to make any item the focus.

Fix: When the list gains focus, if no items are selected, select the first item, if there is one.
This commit is contained in:
David Bailes
2018-11-12 15:27:55 +00:00
parent 4e9c3cfb5f
commit 62f1711cdd
1 changed files with 21 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/widgets/KeyView.cpp
View File

@@ -1232,18 +1232,32 @@ KeyView::OnSetFocus(wxFocusEvent & event)
// Allow further processing // Allow further processing
event.Skip(); event.Skip();
// Refresh the selected line to pull in any changes while
// focus was away...like when setting a NEW key value. This
// will also refresh the visual (highlighted) state.
if (GetSelection() != wxNOT_FOUND) if (GetSelection() != wxNOT_FOUND)
{ {
// Refresh the selected line to pull in any changes while
// focus was away...like when setting a NEW key value. This
// will also refresh the visual (highlighted) state.
RefreshRow(GetSelection()); RefreshRow(GetSelection());
}
#if wxUSE_ACCESSIBILITY #if wxUSE_ACCESSIBILITY
// Tell accessibility of the change // Tell accessibility of the change
mAx->SetCurrentLine(GetSelection()); mAx->SetCurrentLine(GetSelection());
#endif #endif
}
else
{
if (mLines.size() > 0)
{
// if no selection, select first line, if there is one
SelectNode(LineToIndex(0));
}
else
{
#if wxUSE_ACCESSIBILITY
// Tell accessibility, since there may have been a change
mAx->SetCurrentLine(wxNOT_FOUND);
#endif
}
}
} }
// //