From 617c1d87858fbd60a98e854eab596a752b6cde0b Mon Sep 17 00:00:00 2001
From: Paul Licameli <paul.licameli@audacityteam.org>
Date: Thu, 4 Apr 2019 17:42:01 -0400
Subject: [PATCH] Make default value of /Effects/GroupBy match the dialog
 choice

---
 src/menus/PluginMenus.cpp  | 4 ++--
 src/prefs/EffectsPrefs.cpp | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/menus/PluginMenus.cpp b/src/menus/PluginMenus.cpp
index b77784d5a..2ba84d6c1 100644
--- a/src/menus/PluginMenus.cpp
+++ b/src/menus/PluginMenus.cpp
@@ -166,7 +166,7 @@ void AddEffectMenuItems(
 {
    size_t pluginCnt = plugs.size();
 
-   wxString groupBy = gPrefs->Read(wxT("/Effects/GroupBy"), wxT("name"));
+   wxString groupBy = gPrefs->Read(wxT("/Effects/GroupBy"), wxT("sortby:name"));
 
    bool grouped = false;
    if (groupBy.StartsWith(wxT("groupby")))
@@ -340,7 +340,7 @@ MenuTable::BaseItemPtrs PopulateEffectsMenu(
       plug = pm.GetNextPluginForEffectType(type);
    }
 
-   wxString groupby = gPrefs->Read(wxT("/Effects/GroupBy"), wxT("name"));
+   wxString groupby = gPrefs->Read(wxT("/Effects/GroupBy"), wxT("sortby:name"));
 
    using Comparator = bool(*)(const PluginDescriptor*, const PluginDescriptor*);
    Comparator comp1, comp2;
diff --git a/src/prefs/EffectsPrefs.cpp b/src/prefs/EffectsPrefs.cpp
index 595d5cf57..bea7873b0 100644
--- a/src/prefs/EffectsPrefs.cpp
+++ b/src/prefs/EffectsPrefs.cpp
@@ -121,7 +121,7 @@ void EffectsPrefs::PopulateOrExchange(ShuttleGui & S)
 
          wxChoice *c = S.TieChoice(_("S&ort or Group:"),
                                    wxT("/Effects/GroupBy"),
-                                   wxT("name"),
+                                   wxT("sortby:name"),
                                    visualgroups,
                                    prefsgroups);
          if( c ) c->SetMinSize(c->GetBestSize());