Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2026-01-09 14:17:10 +01:00
Code Issues Releases Wiki Activity

Throw by value, catch by reference: don't use pointers...

Browse Source 
... that's what the better books on C++ recommend.
This commit is contained in:
Paul Licameli
2016-02-14 04:35:05 -05:00
parent 7c4c45a0d5
commit 6052b5f9be
7 changed files with 17 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/xml/XMLWriter.cpp
View File

@@ -266,7 +266,7 @@ XMLFileWriter::~XMLFileWriter()
void XMLFileWriter::Open(const wxString &name, const wxString &mode)
{
if (!wxFFile::Open(name, mode))
throw new XMLFileWriterException(_("Error Opening File"));
throw XMLFileWriterException(_("Error Opening File"));
}
void XMLFileWriter::Close()
@@ -287,12 +287,12 @@ void XMLFileWriter::CloseWithoutEndingTags()
wxFFile::Close();
/* i18n-hint: 'flushing' means writing any remaining queued up changes
* to disk that have not yet been written.*/
throw new XMLFileWriterException(_("Error Flushing File"));
throw XMLFileWriterException(_("Error Flushing File"));
}
// Note that this should never fail if flushing worked.
if (!wxFFile::Close())
throw new XMLFileWriterException(_("Error Closing File"));
throw XMLFileWriterException(_("Error Closing File"));
}
void XMLFileWriter::Write(const wxString &data)
@@ -302,7 +302,7 @@ void XMLFileWriter::Write(const wxString &data)
// When writing fails, we try to close the file before throwing the
// exception, so it can at least be deleted.
wxFFile::Close();
throw new XMLFileWriterException(_("Error Writing to File"));
throw XMLFileWriterException(_("Error Writing to File"));
}
}