From 5be54c5612196b16b1df41f3b44cecae7847705c Mon Sep 17 00:00:00 2001
From: Paul Licameli <paul.licameli@audacityteam.org>
Date: Fri, 8 Mar 2019 15:18:20 -0500
Subject: [PATCH] ModuleManager::CreateProviderInstance returns more specific
 type

---
 src/ModuleManager.cpp | 5 ++---
 src/ModuleManager.h   | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/ModuleManager.cpp b/src/ModuleManager.cpp
index 531608c39..e0bbeda29 100755
--- a/src/ModuleManager.cpp
+++ b/src/ModuleManager.cpp
@@ -509,8 +509,7 @@ void ModuleManager::FindAllPlugins(PluginIDs & providers, PluginPaths & paths)
    {
       PluginID providerID = modIDs[i];
 
-      ModuleInterface *module =
-         static_cast<ModuleInterface *>(CreateProviderInstance(providerID, modPaths[i]));
+      auto module = CreateProviderInstance(providerID, modPaths[i]);
 
       if (!module)
          continue;
@@ -553,7 +552,7 @@ bool ModuleManager::RegisterEffectPlugin(const PluginID & providerID, const Plug
    return nFound > 0;
 }
 
-ComponentInterface *ModuleManager::CreateProviderInstance(const PluginID & providerID,
+ModuleInterface *ModuleManager::CreateProviderInstance(const PluginID & providerID,
                                                       const PluginPath & path)
 {
    if (path.empty() && mDynModules.find(providerID) != mDynModules.end())
diff --git a/src/ModuleManager.h b/src/ModuleManager.h
index 9c67f776e..4276e08cb 100644
--- a/src/ModuleManager.h
+++ b/src/ModuleManager.h
@@ -102,7 +102,7 @@ public:
    bool RegisterEffectPlugin(const PluginID & provider, const PluginPath & path,
                        wxString &errMsg);
 
-   ComponentInterface *CreateProviderInstance(const PluginID & provider, const PluginPath & path);
+   ModuleInterface *CreateProviderInstance(const PluginID & provider, const PluginPath & path);
    ComponentInterface *CreateInstance(const PluginID & provider, const PluginPath & path);
    void DeleteInstance(const PluginID & provider, ComponentInterface *instance);