Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-11-23 17:30:17 +01:00
Code Issues Releases Wiki Activity

BHug1488: Don't crash exiting from command-line benchmark test...

Browse Source 
Problem was that cfd7648fce fixed a memory leak
but created a dangling pointer bug, which does not happen during usual run
of Audacity because AudacityProject::OnCloseWindow is reached then before
destroying AudacityProject.

Fixed it by using a std::shared_pointer for the TrackList that both
AudacityProject and TrackPanel must use.
This commit is contained in:
Paul Licameli
2016-08-20 13:58:56 -04:00
parent 05fe684114
commit 5761972dfa
5 changed files with 42 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/TrackPanelAx.cpp
View File

@@ -74,7 +74,7 @@ void TrackPanelAx::SetFocus( Track *track )
if( track == NULL )
{
TrackListIterator iter( mTrackPanel->mTracks );
TrackListIterator iter( mTrackPanel->GetTracks() );
track = iter.First();
}
@@ -122,7 +122,7 @@ bool TrackPanelAx::IsFocused( Track *track )
int TrackPanelAx::TrackNum( Track *target )
{
TrackListIterator iter( mTrackPanel->mTracks );
TrackListIterator iter( mTrackPanel->GetTracks() );
Track *t = iter.First();
int ndx = 0;
@@ -142,7 +142,7 @@ int TrackPanelAx::TrackNum( Track *target )
Track *TrackPanelAx::FindTrack( int num )
{
TrackListIterator iter( mTrackPanel->mTracks );
TrackListIterator iter( mTrackPanel->GetTracks() );
Track *t = iter.First();
int ndx = 0;
@@ -195,7 +195,7 @@ wxAccStatus TrackPanelAx::GetChild( int childId, wxAccessible** child )
// Gets the number of children.
wxAccStatus TrackPanelAx::GetChildCount( int* childCount )
{
TrackListIterator iter( mTrackPanel->mTracks );
TrackListIterator iter( mTrackPanel->GetTracks() );
Track *t = iter.First();
int cnt = 0;