Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-07-20 14:47:49 +02:00
Code Issues Releases Wiki Activity

null checks -- fix Linux crash in drag-dropping files onto app icon?

Browse Source
This commit is contained in:
Paul Licameli 2018-01-03 15:34:49 -05:00
parent 889284555b
commit 50d6e75185
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/ModuleManager.cpp
View File

@ -514,6 +514,9 @@ void ModuleManager::FindAllPlugins(PluginIDList & providers, wxArrayString & pat
ModuleInterface *module = ModuleInterface *module =
static_cast<ModuleInterface *>(CreateProviderInstance(providerID, modPaths[i])); static_cast<ModuleInterface *>(CreateProviderInstance(providerID, modPaths[i]));
if (!module)
continue;
wxArrayString newpaths = module->FindPluginPaths(pm); wxArrayString newpaths = module->FindPluginPaths(pm);
for (size_t i = 0, cnt = newpaths.size(); i < cnt; i++) for (size_t i = 0, cnt = newpaths.size(); i < cnt; i++)
{ {

3
src/PluginManager.cpp
View File

@ -1759,6 +1759,9 @@ bool PluginManager::DropFile(const wxString &fileName)
{ {
auto module = static_cast<ModuleInterface *> auto module = static_cast<ModuleInterface *>
(mm.CreateProviderInstance(plug->GetID(), plug->GetPath())); (mm.CreateProviderInstance(plug->GetID(), plug->GetPath()));
if (! module)
continue;
const auto &ff = module->InstallPath(); const auto &ff = module->InstallPath();
auto extensions = module->FileExtensions(); auto extensions = module->FileExtensions();
if (!ff.empty() && if (!ff.empty() &&