mirror of
https://github.com/cookiengineer/audacity
synced 2025-11-24 14:20:19 +01:00
Changes to the Effect dialog based on QA suggestions
Solves the problem of what the "Settings" button should say by converting it to a bitmap button. Adds the missing "bypass effect" button. The Ok/Cancel buttons are now Apply/Close buttons and the dialog stays open after the apply is done. Record is no longer disabled when an RTP effect is open as the RTP effect now monitors when recording starts and disables its buttons as needed. Added "Play", "Skip forward", and "Skip backward" buttons. While the other stuff is required, this last one is in to get a feel for its usefulness. We'll need to get feedback on it pretty quickly so we can rip it out if need be.
This commit is contained in:
@@ -326,6 +326,9 @@ using std::min;
|
||||
|
||||
AudioIO *gAudioIO;
|
||||
|
||||
DEFINE_EVENT_TYPE(EVT_AUDIOIO_PLAYBACK);
|
||||
DEFINE_EVENT_TYPE(EVT_AUDIOIO_CAPTURE);
|
||||
|
||||
// static
|
||||
int AudioIO::mNextStreamToken = 0;
|
||||
int AudioIO::mCachedPlaybackIndex = -1;
|
||||
@@ -1419,6 +1422,20 @@ int AudioIO::StartStream(WaveTrackArray playbackTracks,
|
||||
}
|
||||
}
|
||||
|
||||
if (mNumPlaybackChannels > 0)
|
||||
{
|
||||
wxCommandEvent e(EVT_AUDIOIO_PLAYBACK);
|
||||
e.SetInt(true);
|
||||
wxTheApp->ProcessEvent(e);
|
||||
}
|
||||
|
||||
if (mNumCaptureChannels > 0)
|
||||
{
|
||||
wxCommandEvent e(EVT_AUDIOIO_CAPTURE);
|
||||
e.SetInt(true);
|
||||
wxTheApp->ProcessEvent(e);
|
||||
}
|
||||
|
||||
mAudioThreadFillBuffersLoopRunning = true;
|
||||
#ifdef EXPERIMENTAL_MIDI_OUT
|
||||
// If audio is not running, mNumFrames will not be incremented and
|
||||
@@ -1685,6 +1702,20 @@ void AudioIO::StopStream()
|
||||
mPortStreamV19 = NULL;
|
||||
}
|
||||
|
||||
if (mNumPlaybackChannels > 0)
|
||||
{
|
||||
wxCommandEvent e(EVT_AUDIOIO_PLAYBACK);
|
||||
e.SetInt(false);
|
||||
wxTheApp->ProcessEvent(e);
|
||||
}
|
||||
|
||||
if (mNumCaptureChannels > 0)
|
||||
{
|
||||
wxCommandEvent e(EVT_AUDIOIO_CAPTURE);
|
||||
e.SetInt(false);
|
||||
wxTheApp->ProcessEvent(e);
|
||||
}
|
||||
|
||||
|
||||
#ifdef EXPERIMENTAL_MIDI_OUT
|
||||
/* Stop Midi playback */
|
||||
|
||||
Reference in New Issue
Block a user