From 48edd2298a2849dcd6f1004d48fe7b07fa59dd98 Mon Sep 17 00:00:00 2001
From: Henric Jungheim <software@henric.org>
Date: Wed, 12 Jul 2017 11:56:21 -0700
Subject: [PATCH] Put the theme data in .rdata/.rodata

---
 src/Theme.cpp | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/Theme.cpp b/src/Theme.cpp
index 638ec7ffd..36bece2e0 100644
--- a/src/Theme.cpp
+++ b/src/Theme.cpp
@@ -192,16 +192,16 @@ WX_DEFINE_USER_EXPORTED_OBJARRAY( ArrayOfColours )
 
 // Include the ImageCache...
 
-static unsigned char DarkImageCacheAsData[] = {
+static const unsigned char DarkImageCacheAsData[] = {
 #include "DarkThemeAsCeeCode.h"
 };
-static unsigned char LightImageCacheAsData[] = {
+static const unsigned char LightImageCacheAsData[] = {
 #include "LightThemeAsCeeCode.h"
 };
-static unsigned char ClassicImageCacheAsData[] = {
+static const unsigned char ClassicImageCacheAsData[] = {
 #include "ClassicThemeAsCeeCode.h"
 };
-static unsigned char HiContrastImageCacheAsData[] = {
+static const unsigned char HiContrastImageCacheAsData[] = {
 #include "HiContrastThemeAsCeeCode.h"
 };
 
@@ -963,24 +963,24 @@ bool ThemeBase::ReadImageCache( teThemeType type, bool bOkIfNotFound)
    else
    {
       size_t ImageSize = 0;
-      char * pImage = NULL;
+      const unsigned char * pImage = nullptr;
       switch( type ){
          default: 
          case themeClassic : 
             ImageSize = sizeof(ClassicImageCacheAsData);
-            pImage = (char *)ClassicImageCacheAsData;
+            pImage = ClassicImageCacheAsData;
             break;
          case themeLight : 
             ImageSize = sizeof(LightImageCacheAsData);
-            pImage = (char *)LightImageCacheAsData;
+            pImage = LightImageCacheAsData;
             break;
          case themeDark : 
             ImageSize = sizeof(DarkImageCacheAsData);
-            pImage = (char *)DarkImageCacheAsData;
+            pImage = DarkImageCacheAsData;
             break;
          case themeHiContrast : 
             ImageSize = sizeof(HiContrastImageCacheAsData);
-            pImage = (char *)HiContrastImageCacheAsData;
+            pImage = HiContrastImageCacheAsData;
             break;
       }