Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-04-30 15:49:41 +02:00
Code Issues Releases Wiki Activity

bug 2300: Limit number of clips in *track* clips property

Browse Source 
Nyquist has a limit (less than 2000) for the number of arguments
which may be exceeded when creating the *track* clips property.
In the event that there are more than 1000 clips in a track,
Audacity will now only add the first 1000 clips to the *track* property
and add NIL as the 1001th.
This commit is contained in:
SteveDaulton 2020-02-02 21:23:59 +00:00
parent 65c174015c
commit 3e94dfdca0
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/effects/nyquist/Nyquist.cpp
View File

@ -1179,10 +1179,18 @@ bool NyquistEffect::ProcessOne()
clips += wxT("(list ");
}
// Each clip is a list (start-time, end-time)
for (const auto clip: ca) {
clips += wxString::Format(wxT("(list (float %s) (float %s))"),
Internat::ToString(clip->GetStartTime()),
Internat::ToString(clip->GetEndTime()));
// Limit number of clips added to avoid argument stack overflow error (bug 2300).
for (size_t i=0; i<ca.size(); i++) {
if (i < 1000) {
clips += wxString::Format(wxT("(list (float %s) (float %s))"),
Internat::ToString(ca[i]->GetStartTime()),
Internat::ToString(ca[i]->GetEndTime()));
} else if (i == 1000) {
// If final clip is NIL, plug-in developer knows there are more than 1000 clips in channel.
clips += "NIL";
} else if (i > 1000) {
break;
}
}
if (mCurNumChannels > 1) clips += wxT(" )");
@ -1203,7 +1211,7 @@ bool NyquistEffect::ProcessOne()
if (!std::isinf(rms) && !std::isnan(rms)) {
rmsString += wxString::Format(wxT("(float %s) "), Internat::ToString(rms));
} else {
rmsString += wxT("nil ");
rmsString += wxT("NIL ");
}
}
// A list of clips for mono, or an array of lists for multi-channel.