Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-12-16 09:31:14 +01:00
Code Issues Releases Wiki Activity

Remove description from PluginDescriptor...

Browse Source 
... it was simply written to registry and read again, serving no other
purpose.

But still write a blank to registry for backwards compatibility of the .cfg
file.

This makes it irrelevant whether the value of IdentInterface::GetDescription()
ought to be localized (registry values should probably not be).

Therefore IdentInterface::GetDescription can return localized, and it's all
right that the return be computed (as in VST effects), rather than
an unlocalized msgid that we rely on as an internal identifier.
This commit is contained in:
Paul Licameli
2017-10-05 14:13:01 -04:00
parent ef25a1187c
commit 3b90538b84
2 changed files with 9 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/PluginManager.h
View File

@@ -66,7 +66,6 @@ public:
wxString GetName(bool translate = true) const;
wxString GetVersion(bool translate = true) const;
wxString GetVendor(bool translate = true) const;
wxString GetDescription(bool translate = true) const;
bool IsEnabled() const;
bool IsValid() const;
@@ -81,7 +80,6 @@ public:
void SetName(const wxString & name);
void SetVersion(const wxString & version);
void SetVendor(const wxString & vendor);
void SetDescription(const wxString & description);
void SetEnabled(bool enable);
void SetValid(bool valid);
@@ -135,7 +133,6 @@ private:
wxString mName;
wxString mVersion;
wxString mVendor;
wxString mDescription;
wxString mProviderID;
bool mEnabled;
bool mValid;