From 3aab1939f0205ad758a0b2d8fb8f4d8ed958f978 Mon Sep 17 00:00:00 2001 From: Steve Daulton Date: Fri, 7 Jul 2017 14:11:53 +0100 Subject: [PATCH] Fix Nyquist message logging Incorrect use of wxLogMessage can cause crash on Windows if '%' present in debug string. --- src/effects/nyquist/Nyquist.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/effects/nyquist/Nyquist.cpp b/src/effects/nyquist/Nyquist.cpp index 9dadb2d21..a39f3a75b 100644 --- a/src/effects/nyquist/Nyquist.cpp +++ b/src/effects/nyquist/Nyquist.cpp @@ -1171,7 +1171,7 @@ bool NyquistEffect::ProcessOne() // If we're not showing debug window, log errors and warnings: if (!mDebugOutput.IsEmpty() && !mDebug && !mTrace) { /* i18n-hint: An effect "returned" a message.*/ - wxLogMessage(wxT("\'") + mName + wxT("\' ") + _("returned:") + wxT("\n") + mDebugOutput); + wxLogMessage(_("\'%s\' returned:\n%s"), mName, mDebugOutput); } // Audacity has no idea how long Nyquist processing will take, but