Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-07-31 07:59:27 +02:00
Code Issues Releases Wiki Activity

More string typing in ErrorReportDialog, remove arg default

Browse Source
This commit is contained in:
Paul Licameli 2021-07-10 10:49:50 -04:00
parent 062abdde5d
commit 3a3ff8ecbe
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/widgets/ErrorReportDialog.cpp
View File

@ -46,7 +46,7 @@ END_EVENT_TABLE()
ErrorReportDialog::ErrorReportDialog( ErrorReportDialog::ErrorReportDialog(
wxWindow* parent, const TranslatableString& dlogTitle, wxWindow* parent, const TranslatableString& dlogTitle,
const TranslatableString& message, const wxString& helpUrl, const TranslatableString& message, const ManualPageID& helpUrl,
const wxString& log, const bool modal) const wxString& log, const bool modal)
: wxDialogWrapper( : wxDialogWrapper(
parent, wxID_ANY, dlogTitle, wxDefaultPosition, wxDefaultSize, parent, wxID_ANY, dlogTitle, wxDefaultPosition, wxDefaultSize,
@ -198,10 +198,11 @@ void ErrorReportDialog::OnDontSend(wxCommandEvent& event)
void ErrorReportDialog::OnHelp(wxCommandEvent& event) void ErrorReportDialog::OnHelp(wxCommandEvent& event)
{ {
if (mHelpUrl.StartsWith(wxT("innerlink:"))) const auto &helpUrl = mHelpUrl.GET();
if (helpUrl.StartsWith(wxT("innerlink:")))
{ {
HelpSystem::ShowHtmlText( HelpSystem::ShowHtmlText(
this, TitleText(mHelpUrl.Mid(10)), HelpText(mHelpUrl.Mid(10)), false, this, TitleText(helpUrl.Mid(10)), HelpText(helpUrl.Mid(10)), false,
true); true);
return; return;
} }
@ -214,7 +215,7 @@ void ShowErrorReportDialog(
const TranslatableString& message, const wxString& helpPage, const TranslatableString& message, const wxString& helpPage,
const wxString& log) const wxString& log)
{ {
ErrorReportDialog dlog(parent, dlogTitle, message, helpPage, log); ErrorReportDialog dlog(parent, dlogTitle, message, helpPage, log, true);
dlog.CentreOnParent(); dlog.CentreOnParent();
dlog.ShowModal(); dlog.ShowModal();

6
src/widgets/ErrorReportDialog.h
View File

@ -37,8 +37,8 @@ class ErrorReportDialog final : public wxDialogWrapper
public: public:
ErrorReportDialog( ErrorReportDialog(
wxWindow* parent, const TranslatableString& dlogTitle, wxWindow* parent, const TranslatableString& dlogTitle,
const TranslatableString& message, const wxString& helpUrl, const TranslatableString& message, const ManualPageID& helpUrl,
const wxString& log, const bool modal = true); const wxString& log, const bool modal);
~ErrorReportDialog(); ~ErrorReportDialog();
@ -50,7 +50,7 @@ private:
std::unique_ptr<audacity::sentry::Report> mReport; std::unique_ptr<audacity::sentry::Report> mReport;
wxString mHelpUrl; ManualPageID mHelpUrl;
wxTextCtrl* mCommentsControl; wxTextCtrl* mCommentsControl;