Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-06-17 00:20:06 +02:00
Code Issues Releases Wiki Activity

Make sure buttons are disabled for "special" commands

Browse Source
This commit is contained in:
Leland Lucius 2015-05-12 10:26:27 -05:00
parent 3000594d2f
commit 3391203e93
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/BatchCommandDialog.cpp
View File

@ -169,8 +169,10 @@ void BatchCommandDialog::OnItemSelected(wxListEvent &event)
EffectManager & em = EffectManager::Get(); EffectManager & em = EffectManager::Get();
PluginID ID = em.GetEffectByIdentifier(command); PluginID ID = em.GetEffectByIdentifier(command);
wxASSERT(!ID.IsEmpty());
mEditParams->Enable(true); // If ID is empty, then the effect wasn't found, in which case, the user must have
// selected one of the "special" commands.
mEditParams->Enable(!ID.IsEmpty());
mUsePreset->Enable(em.HasPresets(ID)); mUsePreset->Enable(em.HasPresets(ID));
if (command == mCommand->GetValue()) if (command == mCommand->GetValue())
@ -179,6 +181,7 @@ void BatchCommandDialog::OnItemSelected(wxListEvent &event)
} }
mCommand->SetValue(command); mCommand->SetValue(command);
wxString params = BatchCommands::GetCurrentParamsFor(command); wxString params = BatchCommands::GetCurrentParamsFor(command);
if (params.IsEmpty()) if (params.IsEmpty())
{ {
@ -216,9 +219,16 @@ void BatchCommandDialog::SetCommandAndParams(const wxString &Command, const wxSt
mParameters->SetValue( Params ); mParameters->SetValue( Params );
int item = mChoices->FindItem(-1, Command); int item = mChoices->FindItem(-1, Command);
if( item != -1 ) if (item != wxNOT_FOUND)
{ {
mChoices->SetItemState(item, wxLIST_STATE_SELECTED, wxLIST_STATE_SELECTED); mChoices->SetItemState(item, wxLIST_STATE_SELECTED, wxLIST_STATE_SELECTED);
mEditParams->Enable( true );
EffectManager & em = EffectManager::Get();
PluginID ID = em.GetEffectByIdentifier(Command);
// If ID is empty, then the effect wasn't found, in which case, the user must have
// selected one of the "special" commands.
mEditParams->Enable(!ID.IsEmpty());
mUsePreset->Enable(em.HasPresets(ID));
} }
} }