Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-08-02 17:09:26 +02:00
Code Issues Releases Wiki Activity

Restrict access to mutating member functions of PluginDescriptor...

Browse Source 
... just enough for the PluginRegistrationDialog to do its work
This commit is contained in:
Paul Licameli 2021-06-19 19:37:24 -04:00
parent 04a0292d1d
commit 2ffd9d84c8
1 changed files with 25 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
src/PluginManager.h
View File

@ -49,11 +49,8 @@ public:
virtual ~PluginDescriptor(); virtual ~PluginDescriptor();
bool IsInstantiated() const; bool IsInstantiated() const;
ComponentInterface *GetInstance();
void SetInstance(std::unique_ptr<ComponentInterface> instance);
PluginType GetPluginType() const; PluginType GetPluginType() const;
void SetPluginType(PluginType type);
// All plugins // All plugins
@ -71,17 +68,6 @@ public:
bool IsEnabled() const; bool IsEnabled() const;
bool IsValid() const; bool IsValid() const;
// These should be passed an untranslated value
void SetID(const PluginID & ID);
void SetProviderID(const PluginID & providerID);
void SetPath(const PluginPath & path);
void SetSymbol(const ComponentInterfaceSymbol & symbol);
// These should be passed an untranslated value wrapped in XO() so
// the value will still be extracted for translation
void SetVersion(const wxString & version);
void SetVendor(const wxString & vendor);
void SetEnabled(bool enable); void SetEnabled(bool enable);
void SetValid(bool valid); void SetValid(bool valid);
@ -100,6 +86,31 @@ public:
bool IsEffectRealtime() const; bool IsEffectRealtime() const;
bool IsEffectAutomatable() const; bool IsEffectAutomatable() const;
// Importer plugins only
const wxString & GetImporterIdentifier() const;
const TranslatableString & GetImporterFilterDescription() const;
const FileExtensions & GetImporterExtensions() const;
private:
friend class PluginManager;
ComponentInterface *GetInstance();
void SetInstance(std::unique_ptr<ComponentInterface> instance);
void SetPluginType(PluginType type);
// These should be passed an untranslated value
void SetID(const PluginID & ID);
void SetProviderID(const PluginID & providerID);
void SetPath(const PluginPath & path);
void SetSymbol(const ComponentInterfaceSymbol & symbol);
// These should be passed an untranslated value wrapped in XO() so
// the value will still be extracted for translation
void SetVersion(const wxString & version);
void SetVendor(const wxString & vendor);
// "family" should be an untranslated string wrapped in wxT() // "family" should be an untranslated string wrapped in wxT()
void SetEffectFamily(const wxString & family); void SetEffectFamily(const wxString & family);
void SetEffectType(EffectType type); void SetEffectType(EffectType type);
@ -109,18 +120,10 @@ public:
void SetEffectRealtime(bool realtime); void SetEffectRealtime(bool realtime);
void SetEffectAutomatable(bool automatable); void SetEffectAutomatable(bool automatable);
// Importer plugins only
const wxString & GetImporterIdentifier() const;
const TranslatableString & GetImporterFilterDescription() const;
const FileExtensions & GetImporterExtensions() const;
void SetImporterIdentifier(const wxString & identifier); void SetImporterIdentifier(const wxString & identifier);
void SetImporterFilterDescription(const TranslatableString & filterDesc); void SetImporterFilterDescription(const TranslatableString & filterDesc);
void SetImporterExtensions(FileExtensions extensions); void SetImporterExtensions(FileExtensions extensions);
private:
// Common // Common
// Among other purposes, PluginDescriptor acts as the resource handle, // Among other purposes, PluginDescriptor acts as the resource handle,