Bug 2491 - Reset Configuration does not reset Extended Import preferences

Better solution...

src/menus/PluginMenus.cpp

@@ -20,7 +20,6 @@
 #include "../effects/EffectManager.h"
 #include "../effects/EffectUI.h"
 #include "../effects/RealtimeEffectManager.h"
-#include "../import/Import.h"
 #include "../prefs/EffectsPrefs.h"
 #include "../prefs/PrefsDialog.h"
 
@@ -408,9 +407,6 @@ void OnResetConfig(const CommandContext &context)
    gPrefs->Write(wxT("/Version/Micro"), AUDACITY_REVISION);
 
    gPrefs->Flush();
-
-   // Bug 2491 - Reset Configuration does not reset Extended Import preferences
-   Importer::Get().ReadImportItems();
 }
 
 void OnManageGenerators(const CommandContext &context)

src/prefs/ExtImportPrefs.cpp

@@ -92,6 +92,9 @@ wxString ExtImportPrefs::HelpPageName()
 /// Creates the dialog and its contents.
 void ExtImportPrefs::Populate()
 {
+   // Ensure Importer has current items
+   Importer::Get().ReadImportItems();
+
    //------------------------- Main section --------------------
    // Now construct the GUI itself.
    // Use 'eIsCreatingFromPrefs' so that the GUI is
@@ -213,6 +216,8 @@ bool ExtImportPrefs::Commit()
    ShuttleGui S(this, eIsSavingToPrefs);
    PopulateOrExchange(S);
 
+   Importer::Get().WriteImportItems();
+
    return true;
 }