Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-10-10 16:43:33 +02:00
Code Issues Releases Wiki Activity

Revert "Bug1848: Mac VoiceOver should read names of choice controls..."

Browse Source 
This reverts commit d2c112600d.

On Windows, it is intentional that SetAccessible is not called for wxChoice in ShuttleGui.
See the commit message of f9ee3cd for background.

Changing this during code freeze and close to creating release candidates would have the danger of introducing bugs.

Fixing this bug needs further discussion. Hopefully the Mac accessibility code can be changed to bring it into line with the changes in the wxWidets accessibility code when we moved to 3.1.1
This commit is contained in:
David Bailes
2019-04-26 09:05:22 +01:00
parent 410746b3d2
commit 21a1260f91
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/ShuttleGui.cpp
View File

@@ -401,10 +401,6 @@ wxChoice * ShuttleGuiBase::AddChoice( const wxString &Prompt,
Style( 0 ) ); Style( 0 ) );
pChoice->SetSizeHints( 180,-1);// Use -1 for 'default size' - Platform specific. pChoice->SetSizeHints( 180,-1);// Use -1 for 'default size' - Platform specific.
#if wxUSE_ACCESSIBILITY
// so that name can be set on a standard control
mpWind->SetAccessible(safenew WindowAccessible(mpWind));
#endif
pChoice->SetName(wxStripMenuCodes(Prompt)); pChoice->SetName(wxStripMenuCodes(Prompt));
if ( Selected >= 0 && Selected < choices.size() ) if ( Selected >= 0 && Selected < choices.size() )
pChoice->SetSelection( Selected ); pChoice->SetSelection( Selected );