1
0
mirror of https://github.com/cookiengineer/audacity synced 2026-04-02 04:24:51 +02:00

Unitary fixes (#598)

* Eliminate unneeded back-pointer to project from non-wave Tracks...

... now that DirManager is gone

* Remove unused declarations

* SampleData::mProject was not used

* Correct ProjectFileIO::GetLibraryError

* Remove unnecessary #include directives
This commit is contained in:
Paul Licameli
2020-07-02 12:42:25 -04:00
committed by GitHub
parent e7fd679ae6
commit 1fcb77ebce
18 changed files with 37 additions and 67 deletions

View File

@@ -123,11 +123,11 @@ static ProjectFileIORegistry::Entry registerFactory{
NoteTrack::Holder TrackFactory::NewNoteTrack()
{
return std::make_shared<NoteTrack>(&mProject);
return std::make_shared<NoteTrack>();
}
NoteTrack::NoteTrack(AudacityProject *project)
: NoteTrackBase(project)
NoteTrack::NoteTrack()
: NoteTrackBase()
{
SetDefaultName(_("Note Track"));
SetName(GetDefaultName());
@@ -172,7 +172,7 @@ Alg_seq &NoteTrack::GetSeq() const
Track::Holder NoteTrack::Clone() const
{
auto duplicate = std::make_shared<NoteTrack>(mProject);
auto duplicate = std::make_shared<NoteTrack>();
duplicate->Init(*this);
// The duplicate begins life in serialized state. Often the duplicate is
// pushed on the Undo stack. Then we want to un-serialize it (or a further
@@ -463,7 +463,7 @@ Track::Holder NoteTrack::Cut(double t0, double t1)
//( std::min( t1, GetEndTime() ) ) - ( std::max( t0, GetStartTime() ) )
//);
auto newTrack = std::make_shared<NoteTrack>(mProject);
auto newTrack = std::make_shared<NoteTrack>();
newTrack->Init(*this);
@@ -477,7 +477,7 @@ Track::Holder NoteTrack::Cut(double t0, double t1)
//AddToDuration( delta );
// What should be done with the rest of newTrack's members?
//(mBottomNote, mProject,
//(mBottomNote,
// mSerializationBuffer, mSerializationLength, mVisibleChannels)
return newTrack;
@@ -490,7 +490,7 @@ Track::Holder NoteTrack::Copy(double t0, double t1, bool) const
double len = t1-t0;
auto newTrack = std::make_shared<NoteTrack>(mProject);
auto newTrack = std::make_shared<NoteTrack>();
newTrack->Init(*this);
@@ -500,7 +500,7 @@ Track::Holder NoteTrack::Copy(double t0, double t1, bool) const
newTrack->SetOffset(0);
// What should be done with the rest of newTrack's members?
// (mBottomNote, mProject, mSerializationBuffer,
// (mBottomNote, mSerializationBuffer,
// mSerializationLength, mVisibleChannels)
return newTrack;