Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-11-09 14:43:57 +01:00
Code Issues Releases Wiki Activity

Exception safety in: overrides of ShowInterface

Browse Source
This commit is contained in:
Paul Licameli
2016-12-16 15:32:56 -05:00
parent 79c3bef2ce
commit 1fad6292a2
7 changed files with 31 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/effects/audiounits/AudioUnitEffect.cpp
View File

@@ -1423,10 +1423,14 @@ bool AudioUnitEffect::ShowInterface(wxWindow *parent, bool forceModal)
{
if (mDialog)
{
mDialog->Close(true);
if( mDialog->Close(true) )
mDialog = nullptr;
return false;
}
// mDialog is null
auto cleanup = valueRestorer( mDialog );
mDialog = mHost->CreateUI(parent, this);
if (!mDialog)
{
@@ -1436,12 +1440,12 @@ bool AudioUnitEffect::ShowInterface(wxWindow *parent, bool forceModal)
if ((SupportsRealtime() || GetType() == EffectTypeAnalyze) && !forceModal)
{
mDialog->Show();
cleanup.release();
return false;
}
bool res = mDialog->ShowModal() != 0;
mDialog = NULL;
return res;
}