Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-08-16 08:34:10 +02:00
Code Issues Releases Wiki Activity

Bug 2261 - Graphic EQ sliders have no frequency labels

Browse Source
This commit is contained in:
James Crook 2020-02-17 14:10:37 +00:00
parent 4d54430c7c
commit 1d9aa20a40
1 changed files with 30 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
src/effects/Equalization.cpp
View File

@ -886,27 +886,39 @@ void EffectEqualization::PopulateOrExchange(ShuttleGui & S)
for (int i = 0; (i < NUMBER_OF_BANDS) && (kThirdOct[i] <= mHiFreq); ++i) for (int i = 0; (i < NUMBER_OF_BANDS) && (kThirdOct[i] <= mHiFreq); ++i)
{ {
mSliders[i] = safenew wxSliderWrapper(pParent, ID_Slider + i, 0, -20, +20, TranslatableString freq = kThirdOct[i] < 1000.
wxDefaultPosition, wxDefaultSize, wxSL_VERTICAL | wxSL_INVERSE); ? XO("%d Hz").Format((int)kThirdOct[i])
: XO("%g kHz").Format(kThirdOct[i] / 1000.);
TranslatableString fNum = kThirdOct[i] < 1000.
? XO("%d").Format((int)kThirdOct[i])
: XO("%gk").Format(kThirdOct[i] / 1000.);
//TranslatableString fUnits = kThirdOct[i] < 1000.
// ? XO("Hz") : XO("kHz");
S.StartVerticalLay();
{
// Abuse of TranslatableString - since there is no
//
S.AddFixedText( fNum );
//S.AddFixedText( fUnits);
mSliders[i] = safenew wxSliderWrapper(pParent, ID_Slider + i, 0, -20, +20,
wxDefaultPosition, wxSize(-1,50), wxSL_VERTICAL | wxSL_INVERSE);
#if wxUSE_ACCESSIBILITY #if wxUSE_ACCESSIBILITY
mSliders[i]->SetAccessible(safenew SliderAx(mSliders[i], XO("%d dB"))); mSliders[i]->SetAccessible(safenew SliderAx(mSliders[i], XO("%d dB")));
#endif #endif
mSlidersOld[i] = 0; mSlidersOld[i] = 0;
mEQVals[i] = 0.; mEQVals[i] = 0.;
//S.SetSizerProportion(1); //S.SetSizerProportion(1);
S.Prop(1) S.Prop(1)
.Name( .Name(freq)
kThirdOct[i] < 1000. .ConnectRoot(
? XO("%d Hz").Format( (int)kThirdOct[i] ) wxEVT_ERASE_BACKGROUND, &EffectEqualization::OnErase)
: XO("%g kHz").Format( kThirdOct[i]/1000. ) .Position(wxEXPAND)
) .Size({ -1, 50 })
.ConnectRoot( .AddWindow(mSliders[i]);
wxEVT_ERASE_BACKGROUND, &EffectEqualization::OnErase) }
.Position(wxEXPAND) S.EndVerticalLay();
.Size( { -1, 150 } )
.AddWindow( mSliders[i] );
} }
S.AddSpace(15,0); S.AddSpace(15,0);
@ -1136,12 +1148,8 @@ void EffectEqualization::PopulateOrExchange(ShuttleGui & S)
if( mOptions == kEqOptionGraphic){ if( mOptions == kEqOptionGraphic){
mPanel->Show( false ); mPanel->Show( false );
szrV->Show(szr1,false);
//szrG->Show( true );
//mUIParent->Layout();
//S.GetParent()->Layout();
wxSize sz = szrV->GetMinSize(); wxSize sz = szrV->GetMinSize();
sz += wxSize( 30, 100); sz += wxSize( 30, 0);
mUIParent->SetMinSize(sz); mUIParent->SetMinSize(sz);
} }
else{ else{