1
0
mirror of https://github.com/cookiengineer/audacity synced 2026-01-15 17:11:23 +01:00

Patch provided by Rob (RPM) to resolve many of the wx3 format string assertions

He wanted to help so I asked if he wanted to track them down.  He agreed and
found more than I probably would have.  And he said there were more, but the
rest were questionable and since he works on Windows, wasn't able to actually
test.

I give a few of the ones he did find a go and they do indeed get rid of the
assertions.

(Basically, a 64-bit/32-bit issue, easily resolved with a typecast.)
This commit is contained in:
lllucius@gmail.com
2014-10-19 03:08:10 +00:00
parent 3361b7e61b
commit 1b993ccd08
8 changed files with 16 additions and 15 deletions

View File

@@ -714,13 +714,13 @@ bool CompressorDialog::TransferDataFromWindow()
mPanel->noisefloor = noisefloor;
mPanel->ratio = ratio;
mThresholdLabel->SetName(wxString::Format(_("Threshold %d dB"), (int)threshold));
mThresholdLabel->SetName(wxString::Format(_("Threshold %d dB"), (int) threshold));
/* i18n-hint: usually leave this as is as dB doesn't get translated*/
mThresholdText->SetLabel(wxString::Format(_("%3d dB"), (int)threshold));
mThresholdText->SetLabel(wxString::Format(_("%3d dB"), (int) threshold));
mThresholdText->SetName(mThresholdText->GetLabel()); // fix for bug 577 (NVDA/Narrator screen readers do not read static text in dialogs)
mNoiseFloorLabel->SetName(wxString::Format(_("Noise Floor %d dB"), (int)noisefloor));
mNoiseFloorText->SetLabel(wxString::Format(_("%3d dB"), (int)noisefloor));
mNoiseFloorLabel->SetName(wxString::Format(_("Noise Floor %d dB"), (int) noisefloor));
mNoiseFloorText->SetLabel(wxString::Format(_("%3d dB"), (int) noisefloor));
mNoiseFloorText->SetName(mNoiseFloorText->GetLabel()); // fix for bug 577 (NVDA/Narrator screen readers do not read static text in dialogs)
if (mRatioSlider->GetValue()%2 == 0) {

View File

@@ -147,7 +147,7 @@ static void LoadLadspaEffect(wxSortedArrayString &uniq, wxString fname,
data = mainFn(index);
while(data) {
wxString uniqid = wxString::Format(wxT("%08x-%s"), data->UniqueID, LAT1CTOWX(data->Label).c_str());
wxString uniqid = wxString::Format(wxT("%08x-%s"), (int)data->UniqueID, LAT1CTOWX(data->Label).c_str());
if (uniq.Index(uniqid) == wxNOT_FOUND) {
uniq.Add(uniqid);
std::set<wxString> categories;