mirror of
https://github.com/cookiengineer/audacity
synced 2025-10-19 17:11:12 +02:00
Fix for bug #833
This allows duplicate items in the effects menus and provides a means to uniquely identify each item.
This commit is contained in:
@@ -65,12 +65,6 @@ VampEffectsModule::~VampEffectsModule()
|
||||
// IdentInterface implementation
|
||||
// ============================================================================
|
||||
|
||||
wxString VampEffectsModule::GetID()
|
||||
{
|
||||
// Can be anything, but this is a v4 UUID
|
||||
return wxT("33a86140-7310-4bdf-ad8e-a4af29079f61");
|
||||
}
|
||||
|
||||
wxString VampEffectsModule::GetPath()
|
||||
{
|
||||
return mPath;
|
||||
@@ -225,14 +219,12 @@ bool VampEffectsModule::RegisterPlugin(PluginManagerInterface & WXUNUSED(pm), co
|
||||
return false;
|
||||
}
|
||||
|
||||
bool VampEffectsModule::IsPluginValid(const PluginID & WXUNUSED(ID),
|
||||
const wxString & path)
|
||||
bool VampEffectsModule::IsPluginValid(const wxString & path)
|
||||
{
|
||||
return wxFileName::FileExists(path);
|
||||
}
|
||||
|
||||
IdentInterface *VampEffectsModule::CreateInstance(const PluginID & WXUNUSED(ID),
|
||||
const wxString & WXUNUSED(path))
|
||||
IdentInterface *VampEffectsModule::CreateInstance(const wxString & WXUNUSED(path))
|
||||
{
|
||||
// Nothing to do here yet since we are autoregistering (and creating legacy
|
||||
// effects anyway).
|
||||
|
@@ -26,7 +26,6 @@ public:
|
||||
|
||||
// IdentInterface implementatino
|
||||
|
||||
virtual wxString GetID();
|
||||
virtual wxString GetPath();
|
||||
virtual wxString GetSymbol();
|
||||
virtual wxString GetName();
|
||||
@@ -43,9 +42,9 @@ public:
|
||||
virtual wxArrayString FindPlugins(PluginManagerInterface & pm);
|
||||
virtual bool RegisterPlugin(PluginManagerInterface & pm, const wxString & path);
|
||||
|
||||
virtual bool IsPluginValid(const PluginID & ID, const wxString & path);
|
||||
virtual bool IsPluginValid(const wxString & path);
|
||||
|
||||
virtual IdentInterface *CreateInstance(const PluginID & ID, const wxString & path);
|
||||
virtual IdentInterface *CreateInstance(const wxString & path);
|
||||
virtual void DeleteInstance(IdentInterface *instance);
|
||||
|
||||
// VampEffectModule implementation
|
||||
|
@@ -68,11 +68,6 @@ VampEffect::~VampEffect()
|
||||
// IdentInterface implementation
|
||||
// ============================================================================
|
||||
|
||||
wxString VampEffect::GetID()
|
||||
{
|
||||
return mName;
|
||||
}
|
||||
|
||||
wxString VampEffect::GetPath()
|
||||
{
|
||||
Vamp::HostExt::PluginLoader *loader = Vamp::HostExt::PluginLoader::getInstance();
|
||||
|
@@ -40,7 +40,6 @@ class VampEffect : public Effect {
|
||||
|
||||
// IdentInterface implementation
|
||||
|
||||
virtual PluginID GetID();
|
||||
virtual wxString GetPath();
|
||||
virtual wxString GetSymbol();
|
||||
virtual wxString GetName();
|
||||
|
Reference in New Issue
Block a user