Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-11-23 17:30:17 +01:00
Code Issues Releases Wiki Activity

Eliminate the confusing mask from CommandManager entries...

Browse Source 
... In fact it was only ever different from flags when flags had the special
NoAutoSelect and mask did not.  Now put that bit in the mask too, and make
the special NoAutoSelect always true in MenuManager::GetUpdateFlags().  This
still preserves the intended effects of NoAutoSelect.
This commit is contained in:
Paul Licameli
2019-06-13 16:56:05 -04:00
parent 64650b9a55
commit 0f2278d394
4 changed files with 15 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/commands/CommandManager.h
View File

@@ -81,7 +81,6 @@ struct CommandListEntry
bool isEffect;
bool hasDialog;
CommandFlag flags;
CommandMask mask;
bool useStrictFlags{ false };
};
@@ -159,8 +158,6 @@ class AUDACITY_DLL_API CommandManager final
{ bIsEffect = true; return std::move(*this); }
Options &&Parameter (const CommandParameter &value) &&
{ parameter = value; return std::move(*this); }
Options &&Mask (CommandMask value) &&
{ mask = value; return std::move(*this); }
Options &&LongName (const wxString &value) &&
{ longName = value; return std::move(*this); }
Options &&IsGlobal () &&
@@ -172,7 +169,6 @@ class AUDACITY_DLL_API CommandManager final
int check{ -1 }; // default value means it's not a check item
bool bIsEffect{ false };
CommandParameter parameter{};
CommandMask mask{ NoFlagsSpecified };
wxString longName{}; // translated
bool global{ false };
bool useStrictFlags{ false };
@@ -216,7 +212,7 @@ class AUDACITY_DLL_API CommandManager final
void EndOccultCommands();
void SetCommandFlags(const CommandID &name, CommandFlag flags, CommandMask mask);
void SetCommandFlags(const CommandID &name, CommandFlag flags);
//
// Modifying menus