Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-06-17 16:40:07 +02:00
Code Issues Releases Wiki Activity

Make "FIXME" comments be "FIX-ME" for consistency with themselves and "ANSWER-ME" comments, in case somebody ever wants to search for these things... ;-)

Browse Source
This commit is contained in:
v.audacity 2011-03-26 01:11:51 +00:00
parent 0bf69e6112
commit 0bd3f11f41
5 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Menus.cpp
View File

@ -1331,7 +1331,7 @@ void AudacityProject::RebuildMenuBar()
// Under Windows we delete the menus, since we will soon recreate them. // Under Windows we delete the menus, since we will soon recreate them.
// rather oddly, the menus don't vanish as a result of doing this. // rather oddly, the menus don't vanish as a result of doing this.
// Under Linux we can't delete them as this crashes gtk2.... // Under Linux we can't delete them as this crashes gtk2....
// FIXME: So we have a memory leak of menu items under linux? Oops. // FIX-ME: So we have a memory leak of menu items under linux? Oops.
#ifdef __WXMSW__ #ifdef __WXMSW__
wxMenuBar *menuBar = GetMenuBar(); wxMenuBar *menuBar = GetMenuBar();

2
src/Resample.cpp
View File

@ -180,7 +180,7 @@ Resample::Resample(bool useBestMethod, double minFactor, double maxFactor)
{ {
if (!src_is_valid_ratio (minFactor) || !src_is_valid_ratio (maxFactor)) { if (!src_is_valid_ratio (minFactor) || !src_is_valid_ratio (maxFactor)) {
fprintf(stderr, "libsamplerate supports only resampling factors between 1/SRC_MAX_RATIO and SRC_MAX_RATIO.\n"); fprintf(stderr, "libsamplerate supports only resampling factors between 1/SRC_MAX_RATIO and SRC_MAX_RATIO.\n");
// FIXME: Audacity will hang after this if branch. // FIX-ME: Audacity will hang after this if branch.
mHandle = NULL; mHandle = NULL;
return; return;
} }

2
src/WaveTrack.cpp
View File

@ -2115,7 +2115,7 @@ bool WaveTrack::Resample(int rate, ProgressDialog *progress)
for (WaveClipList::compatibility_iterator it=GetClipIterator(); it; it=it->GetNext()) for (WaveClipList::compatibility_iterator it=GetClipIterator(); it; it=it->GetNext())
if (!it->GetData()->Resample(rate, progress)) if (!it->GetData()->Resample(rate, progress))
{ {
// FIXME: The track is now in an inconsistent state since some // FIX-ME: The track is now in an inconsistent state since some
// clips are resampled and some are not // clips are resampled and some are not
return false; return false;
} }

4
src/export/ExportFFmpegDialogs.cpp
View File

@ -502,7 +502,7 @@ FFmpegPresets::FFmpegPresets()
FFmpegPresets::~FFmpegPresets() FFmpegPresets::~FFmpegPresets()
{ {
XMLFileWriter writer; XMLFileWriter writer;
// FIXME: Catch XMLFileWriterException // FIX-ME: Catch XMLFileWriterException
wxFileName xmlFileName(FileNames::DataDir(), wxT("ffmpeg_presets.xml")); wxFileName xmlFileName(FileNames::DataDir(), wxT("ffmpeg_presets.xml"));
writer.Open(xmlFileName.GetFullPath(),wxT("wb")); writer.Open(xmlFileName.GetFullPath(),wxT("wb"));
WriteXMLHeader(writer); WriteXMLHeader(writer);
@ -519,7 +519,7 @@ void FFmpegPresets::ImportPresets(wxString &filename)
void FFmpegPresets::ExportPresets(wxString &filename) void FFmpegPresets::ExportPresets(wxString &filename)
{ {
XMLFileWriter writer; XMLFileWriter writer;
// FIXME: Catch XMLFileWriterException // FIX-ME: Catch XMLFileWriterException
writer.Open(filename,wxT("wb")); writer.Open(filename,wxT("wb"));
WriteXMLHeader(writer); WriteXMLHeader(writer);
WriteXML(writer); WriteXML(writer);

10
src/widgets/Ruler.cpp
View File

@ -689,7 +689,7 @@ void Ruler::Tick(int pos, double d, bool major, bool minor)
wxCoord strW, strH, strD, strL; wxCoord strW, strH, strD, strL;
int strPos, strLen, strLeft, strTop; int strPos, strLen, strLeft, strTop;
// FIXME: We don't draw a tick if of end of our label arrays // FIX-ME: We don't draw a tick if of end of our label arrays
// But we shouldn't have an array of labels. // But we shouldn't have an array of labels.
if( mNumMinorMinor >= mLength ) if( mNumMinorMinor >= mLength )
return; return;
@ -749,7 +749,7 @@ void Ruler::Tick(int pos, double d, bool major, bool minor)
} }
// FIXME: we shouldn't even get here if strPos < 0. // FIX-ME: we shouldn't even get here if strPos < 0.
// Ruler code currently does not handle very small or // Ruler code currently does not handle very small or
// negative sized windows (i.e. don't draw) properly. // negative sized windows (i.e. don't draw) properly.
if( strPos < 0 ) if( strPos < 0 )
@ -801,7 +801,7 @@ void Ruler::TickCustom(int labelIdx, bool major, bool minor)
wxCoord strW, strH, strD, strL; wxCoord strW, strH, strD, strL;
int strPos, strLen, strLeft, strTop; int strPos, strLen, strLeft, strTop;
// FIXME: We don't draw a tick if of end of our label arrays // FIX-ME: We don't draw a tick if of end of our label arrays
// But we shouldn't have an array of labels. // But we shouldn't have an array of labels.
if( mNumMinor >= mLength ) if( mNumMinor >= mLength )
return; return;
@ -863,7 +863,7 @@ void Ruler::TickCustom(int labelIdx, bool major, bool minor)
} }
// FIXME: we shouldn't even get here if strPos < 0. // FIX-ME: we shouldn't even get here if strPos < 0.
// Ruler code currently does not handle very small or // Ruler code currently does not handle very small or
// negative sized windows (i.e. don't draw) properly. // negative sized windows (i.e. don't draw) properly.
if( strPos < 0 ) if( strPos < 0 )
@ -978,7 +978,7 @@ void Ruler::Update(TimeTrack* timetrack)// Envelope *speedEnv, long minSpeed, lo
mRect = wxRect(0,0, 0,mLength); mRect = wxRect(0,0, 0,mLength);
} }
// FIXME: Surely we do not need to allocate storage for the labels? // FIX-ME: Surely we do not need to allocate storage for the labels?
// We can just recompute them as we need them? Yes, but only if // We can just recompute them as we need them? Yes, but only if
// mCustom is false!!!! // mCustom is false!!!!